[GitHub] [spark] Hisoka-X commented on pull request #42194: [SPARK-41471][SQL] Reduce Spark shuffle when only one side of a join is KeyGroupedPartitioning

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on PR #42194:
URL: https://github.com/apache/spark/pull/42194#issuecomment-1678670922

   > I'm wondering, will this work if other SPJ flags: spark.sql.sources.v2.bucketing.partiallyClusteredDistribution.enabled and spark.sql.sources.v2.bucketing.pushPartValues.enabled are set to true, and we have case of multiple split for a partition?
   > 
   > In that case, it seems the BatchScanExec of the side with KeyGroupedPartitioning will group partition splits, will it make it out-of-sync with the other side using KeyGroupedPartitioner?
   > 
   > It may also be hard to work with #42306 which uses a similar mechanism to group partition splits?
   
   This is a problem, let me add a test case for this, maybe we should use partitionValue which after group partition splits. Thanks for point that, cc @sunchao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org