You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Jungtaek Lim <ka...@gmail.com> on 2017/12/22 09:26:25 UTC

Porting back STORM-1605: storm shell script should use /bin/env python to check python version

Hi devs,

Don't we want to port back STORM-1605 to 1.x version lines as well?
https://issues.apache.org/jira/browse/STORM-1605

Porting back doesn't require +1 (and doesn't even require PR), so I just
would want to double check with others before going forward.

Thanks,
Jungtaek Lim (HeartSaVioR)

Re: Porting back STORM-1605: storm shell script should use /bin/env python to check python version

Posted by "P. Taylor Goetz" <pt...@gmail.com>.
I’m okay with the change, but would recommend holding off for feedback from representatives of other active projects like streamparse, mesos, etc. I think/hope they are at least lurking on this list (though it is winter holiday season in many places, so responses could be delayed).

-Taylor

> On Dec 22, 2017, at 10:29 PM, Jungtaek Lim <ka...@gmail.com> wrote:
> 
> Most of the cases it shouldn't break existing setups, but I'm not 100% sure
> of that.
> 
> Rationalization of this thread is to address concern on user group [1], as
> you may noticed, so looks like both approaches has a downside. For some
> cases 1.x storm script will not work (users have to modify storm script or
> python environment), but fixing it may break existing setup.
> 
> I'll wait for more inputs, but if we don't have any, I'll just guide to
> modify storm.py script manually.
> 
> Thanks,
> Jungtaek Lim (HeartSaVioR)
> 
> 1.
> http://mail-archives.apache.org/mod_mbox/storm-user/201712.mbox/%3CCACqaReK47wGa2Psd4feOEdDzxGFgbinAuj4dXgATZkn_2HQbaQ%40mail.gmail.com%3E
> 
> 2017년 12월 22일 (금) 오후 11:54, Stig Rohde Døssing <st...@gmail.com>님이
> 작성:
> 
>> Depends whether it is likely to break existing setups. If so I'd rather we
>> don't put it in a minor version.
>> 
>> 2017-12-22 10:26 GMT+01:00 Jungtaek Lim <ka...@gmail.com>:
>> 
>>> Hi devs,
>>> 
>>> Don't we want to port back STORM-1605 to 1.x version lines as well?
>>> https://issues.apache.org/jira/browse/STORM-1605
>>> 
>>> Porting back doesn't require +1 (and doesn't even require PR), so I just
>>> would want to double check with others before going forward.
>>> 
>>> Thanks,
>>> Jungtaek Lim (HeartSaVioR)
>>> 
>>

Re: Porting back STORM-1605: storm shell script should use /bin/env python to check python version

Posted by Jungtaek Lim <ka...@gmail.com>.
Most of the cases it shouldn't break existing setups, but I'm not 100% sure
of that.

Rationalization of this thread is to address concern on user group [1], as
you may noticed, so looks like both approaches has a downside. For some
cases 1.x storm script will not work (users have to modify storm script or
python environment), but fixing it may break existing setup.

I'll wait for more inputs, but if we don't have any, I'll just guide to
modify storm.py script manually.

Thanks,
Jungtaek Lim (HeartSaVioR)

1.
http://mail-archives.apache.org/mod_mbox/storm-user/201712.mbox/%3CCACqaReK47wGa2Psd4feOEdDzxGFgbinAuj4dXgATZkn_2HQbaQ%40mail.gmail.com%3E

2017년 12월 22일 (금) 오후 11:54, Stig Rohde Døssing <st...@gmail.com>님이
작성:

> Depends whether it is likely to break existing setups. If so I'd rather we
> don't put it in a minor version.
>
> 2017-12-22 10:26 GMT+01:00 Jungtaek Lim <ka...@gmail.com>:
>
> > Hi devs,
> >
> > Don't we want to port back STORM-1605 to 1.x version lines as well?
> > https://issues.apache.org/jira/browse/STORM-1605
> >
> > Porting back doesn't require +1 (and doesn't even require PR), so I just
> > would want to double check with others before going forward.
> >
> > Thanks,
> > Jungtaek Lim (HeartSaVioR)
> >
>

Re: Porting back STORM-1605: storm shell script should use /bin/env python to check python version

Posted by Stig Rohde Døssing <st...@gmail.com>.
Depends whether it is likely to break existing setups. If so I'd rather we
don't put it in a minor version.

2017-12-22 10:26 GMT+01:00 Jungtaek Lim <ka...@gmail.com>:

> Hi devs,
>
> Don't we want to port back STORM-1605 to 1.x version lines as well?
> https://issues.apache.org/jira/browse/STORM-1605
>
> Porting back doesn't require +1 (and doesn't even require PR), so I just
> would want to double check with others before going forward.
>
> Thanks,
> Jungtaek Lim (HeartSaVioR)
>