svn commit: r1332492 - in /hbase/branches/0.90: CHANGES.txt src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java

[to...@apache.org]

Author: todd
Date: Tue May  1 01:38:14 2012
New Revision: 1332492

URL: http://svn.apache.org/viewvc?rev=1332492&view=rev
Log:
HBASE-5908. TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan.

Modified:
    hbase/branches/0.90/CHANGES.txt
    hbase/branches/0.90/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java

Modified: hbase/branches/0.90/CHANGES.txt
URL: http://svn.apache.org/viewvc/hbase/branches/0.90/CHANGES.txt?rev=1332492&r1=1332491&r2=1332492&view=diff
==============================================================================
--- hbase/branches/0.90/CHANGES.txt (original)
+++ hbase/branches/0.90/CHANGES.txt Tue May  1 01:38:14 2012
@@ -24,6 +24,7 @@ Release 0.90.7 - Unreleased
    HBASE-5833  0.92 build has been failing pretty consistently on TestMasterFailover.
    HBASE-5850  Refuse operations from Admin before master is initialized - fix for all branches (xufeng)
    HBASE-5873  TimeOut Monitor thread should be started after atleast one region server registers. (rajeshbabu)
+   HBASE-5908  TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog (Gregory Chanan)
 
   IMPROVEMENT
    HBASE-5588  Deprecate/remove AssignmentManager#clearRegionFromTransition

Modified: hbase/branches/0.90/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.90/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java?rev=1332492&r1=1332491&r2=1332492&view=diff
==============================================================================
--- hbase/branches/0.90/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java (original)
+++ hbase/branches/0.90/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java Tue May  1 01:38:14 2012
@@ -113,8 +113,6 @@ public class TestHLogSplit {
   @BeforeClass
   public static void setUpBeforeClass() throws Exception {
     TEST_UTIL.getConfiguration().
-            setBoolean("dfs.support.append", true);
-    TEST_UTIL.getConfiguration().
             setStrings("hbase.rootdir", hbaseDir.toString());
     TEST_UTIL.getConfiguration().
             setClass("hbase.regionserver.hlog.writer.impl",
@@ -1034,7 +1032,9 @@ public class TestHLogSplit {
 
     switch (corruption) {
       case APPEND_GARBAGE:
-        out = fs.append(path);
+        fs.delete(path, false);
+        out = fs.create(path);
+        out.write(corrupted_bytes);
         out.write("-----".getBytes());
         closeOrFlush(close, out);
         break;