You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/13 06:54:51 UTC
[GitHub] [iotdb] krystal-xiao opened a new pull request #4144: Update Configuration parameters
krystal-xiao opened a new pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144
Upate :
1. commit c7267da88eafde78d154093535f77fabc2e54e8e
update Chinese Configuration parameter
2. commit 448556d01f27a71365a5a87566a8553550a1380d
update English Configuration parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735619665
##########
File path: docs/UserGuide/Advanced-Features/UDF-User-Defined-Function.md
##########
@@ -23,19 +23,19 @@
# User Defined Function (UDF)
-IoTDB provides a variety of built-in functions to meet your computing needs, and you can also create user defined functions to meet more computing needs.
+UDF (User Defined Function) is a user-defined function.IoTDB provides a variety of built-in functions to meet your computing needs, and you can also create user defined functions to meet more computing needs.
Review comment:
ok !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735627515
##########
File path: docs/UserGuide/Administration-Management/Administration.md
##########
@@ -30,17 +30,17 @@ At the same time, in the JAVA programming environment, you can use the [Java JDB
### User
-The user is the legal user of the database. A user corresponds to a unique username and has a password as a means of authentication. Before using a database, a person must first provide a legitimate username and password to make himself/herself a user.
+The user is the legitimate user of the database. A user corresponds to a unique username and has a password as a means of authentication. Before using the database, a person must first provide a legal (that is, stored in the database) user name and password to make himself a user.
Review comment:
ok!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734935119
##########
File path: docs/UserGuide/API/Programming-Java-Native-API.md
##########
@@ -211,61 +211,71 @@ SessionDataSet executeQueryStatement(String sql)
void executeNonQueryStatement(String sql)
```
+* Create a physical quantity template
+```
-### Native APIs for profiling network cost
+* name: template name
+* measurements: List of measurements, if it is a single measurement, just put it's name
+* into a list and add to measurements if it is a vector measurement, put all measurements of
+* the vector into a list and add to measurements
+* dataTypes: List of datatypes, if it is a single measurement, just put it's type into a
+* list and add to dataTypes if it is a vector measurement, put all types of the vector
+* into a list and add to dataTypes
+* encodings: List of encodings, if it is a single measurement, just put it's encoding into
+* a list and add to encodings if it is a vector measurement, put all encodings of the
+* vector into a list and add to encodings
+* compressors: List of compressors
+void createSchemaTemplate(
+ String templateName,
+ List<String> schemaName,
+ List<List<String>> measurements,
+ List<List<TSDataType>> dataTypes,
+ List<List<TSEncoding>> encodings,
+ List<CompressionType> compressors)
+```
-* Test the network and client cost of insertRecords. This method NOT insert data into database and server just return after accept the request, this method should be used to test other time cost in client
+* Mount the physical quantity template named'templateName' to the path'prefixPath'. Before performing this step, you need to create a physical quantity template named'templateName'
```java
-void testInsertRecords(List<String> deviceIds, List<Long> times,
- List<List<String>> measurementsList, List<List<String>> valuesList)
-```
- or
-```java
-void testInsertRecords(List<String> deviceIds, List<Long> times,
- List<List<String>> measurementsList, List<List<TSDataType>> typesList,
- List<List<Object>> valuesList)
+void setSchemaTemplate(String templateName, String prefixPath)
```
-* Test the network and client cost of insertRecordsOfOneDevice.
-This method NOT insert data into database and server just return after accept the request,
-this method should be used to test other time cost in client
+
+### Test APIs Description
Review comment:
“for profiling network cost” is meaningful. It tells users when they should use these API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734935603
##########
File path: docs/UserGuide/Administration-Management/Administration.md
##########
@@ -116,7 +116,7 @@ At present, there is no conflicting privilege in IoTDB, so the real privileges o
It should be noted that if users have a privilege (corresponding to operation A) themselves and their roles contain the same privilege, then revoking the privilege from the users themselves alone can not prohibit the users from performing operation A, since it is necessary to revoke the privilege from the role, or revoke the role from the user. Similarly, revoking the privilege from the users's roles alone can not prohibit the users from performing operation A.
-At the same time, changes to roles are immediately reflected on all users who own the roles. For example, adding certain privileges to roles will immediately give all users who own the roles corresponding privileges, and deleting certain privileges will also deprive the corresponding users of the privileges (unless the users themselves have the privileges).
+At the same time, the modification of the role will be immediately reflected on all users who have the role. For example, adding certain privileges to roles will immediately give all users who have the roles corresponding privileges, and deleting certain privileges will also deprive the corresponding users of the privileges (unless the user have the privileges).
Review comment:
"unless the user have the privileges" -> "unless the users have the privileges"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734936127
##########
File path: docs/UserGuide/Advanced-Features/UDF-User-Defined-Function.md
##########
@@ -96,18 +96,18 @@ Please refer to the Javadoc for the usage of `UDFParameterValidator`.
### void beforeStart(UDFParameters parameters, UDTFConfigurations configurations) throws Exception
-This method is mainly used to customize UDTF. In this method, the user can do the following things:
+This method is mainly used to customize UDTF. The methods of beforestart do three functions:
Review comment:
the previous version is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735630564
##########
File path: docs/UserGuide/API/Programming-TsFile-API.md
##########
@@ -225,10 +225,10 @@ A TsFile is generated by the following three steps and the complete code is give
* encoding: The data encoding.
- * compression: The data compression.
+ * compression: The data compression. Now supports UNCOMPRESSED and SNAPPY.
- * props: Properties for special data types.Such as `max_point_number` for `FLOAT` and `DOUBLE`, `max_string_length` for
- `TEXT`. Use as string pairs into a map such as ("max_point_number", "3").
+ * props: Properties for special data types.Such as `FLOAT` and `DOUBLE` can set `max_point_number` , `TEXT` can set `max_string_length`.
Review comment:
ok, I change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735654990
##########
File path: docs/UserGuide/API/Programming-Java-Native-API.md
##########
@@ -211,61 +211,71 @@ SessionDataSet executeQueryStatement(String sql)
void executeNonQueryStatement(String sql)
```
+* Create a physical quantity template
+```
-### Native APIs for profiling network cost
+* name: template name
+* measurements: List of measurements, if it is a single measurement, just put it's name
+* into a list and add to measurements if it is a vector measurement, put all measurements of
+* the vector into a list and add to measurements
+* dataTypes: List of datatypes, if it is a single measurement, just put it's type into a
+* list and add to dataTypes if it is a vector measurement, put all types of the vector
+* into a list and add to dataTypes
+* encodings: List of encodings, if it is a single measurement, just put it's encoding into
+* a list and add to encodings if it is a vector measurement, put all encodings of the
+* vector into a list and add to encodings
+* compressors: List of compressors
+void createSchemaTemplate(
+ String templateName,
+ List<String> schemaName,
+ List<List<String>> measurements,
+ List<List<TSDataType>> dataTypes,
+ List<List<TSEncoding>> encodings,
+ List<CompressionType> compressors)
+```
-* Test the network and client cost of insertRecords. This method NOT insert data into database and server just return after accept the request, this method should be used to test other time cost in client
+* Mount the physical quantity template named'templateName' to the path'prefixPath'. Before performing this step, you need to create a physical quantity template named'templateName'
```java
-void testInsertRecords(List<String> deviceIds, List<Long> times,
- List<List<String>> measurementsList, List<List<String>> valuesList)
-```
- or
-```java
-void testInsertRecords(List<String> deviceIds, List<Long> times,
- List<List<String>> measurementsList, List<List<TSDataType>> typesList,
- List<List<Object>> valuesList)
+void setSchemaTemplate(String templateName, String prefixPath)
```
-* Test the network and client cost of insertRecordsOfOneDevice.
-This method NOT insert data into database and server just return after accept the request,
-this method should be used to test other time cost in client
+
+### Test APIs Description
Review comment:
ok!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735605117
##########
File path: docs/Download/README.md
##########
@@ -69,7 +69,7 @@
Legacy version are available here: [https://archive.apache.org/dist/iotdb/](https://archive.apache.org/dist/iotdb/)
-**<font color=red>Attention</font>**:
+**<font color=red>Upgrade Notes</font>**:
Review comment:
OK, Got it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734935433
##########
File path: docs/UserGuide/API/Programming-TsFile-API.md
##########
@@ -225,10 +225,10 @@ A TsFile is generated by the following three steps and the complete code is give
* encoding: The data encoding.
- * compression: The data compression.
+ * compression: The data compression. Now supports UNCOMPRESSED and SNAPPY.
Review comment:
not only UNCOMPRESSED and SNAPPY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734935295
##########
File path: docs/UserGuide/API/Programming-Java-Native-API.md
##########
@@ -294,139 +304,13 @@ For examples of aligned timeseries and measurement template, you can refer to `e
+### Coding Examples
-### New Interfaces
Review comment:
Why remove this part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734935752
##########
File path: docs/UserGuide/Advanced-Features/UDF-User-Defined-Function.md
##########
@@ -68,7 +68,7 @@ The following table shows all the interfaces available for user implementation.
| `void transform(Row row, PointCollector collector) throws Exception` | This method is called by the framework. This data processing method will be called when you choose to use the `RowByRowAccessStrategy` strategy (set in `beforeStart`) to consume raw data. Input data is passed in by `Row`, and the transformation result should be output by `PointCollector`. You need to call the data collection method provided by `collector` to determine the output data. | Required to implement at least one `transform` method |
| `void transform(RowWindow rowWindow, PointCollector collector) throws Exception` | This method is called by the framework. This data processing method will be called when you choose to use the `SlidingSizeWindowAccessStrategy` or `SlidingTimeWindowAccessStrategy` strategy (set in `beforeStart`) to consume raw data. Input data is passed in by `RowWindow`, and the transformation result should be output by `PointCollector`. You need to call the data collection method provided by `collector` to determine the output data. | Required to implement at least one `transform` method |
| `void terminate(PointCollector collector) throws Exception` | This method is called by the framework. This method will be called once after all `transform` calls have been executed. In a single UDF query, this method will and will only be called once. You need to call the data collection method provided by `collector` to determine the output data. | Optional |
-| `void beforeDestroy() ` | This method is called by the framework after the last input data is processed, and will only be called once in the life cycle of each UDF instance. | Optional |
+| `void beforeDestroy() ` | End method of UDTF. This method is called by the framework after the last input data is processed, and will only be called once in the life cycle of each UDF instance. | Optional |
Review comment:
"End method of UDTF" -> how about "the last step in the UDTF lifecycle"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao closed pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao closed pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734935558
##########
File path: docs/UserGuide/Administration-Management/Administration.md
##########
@@ -30,17 +30,17 @@ At the same time, in the JAVA programming environment, you can use the [Java JDB
### User
-The user is the legal user of the database. A user corresponds to a unique username and has a password as a means of authentication. Before using a database, a person must first provide a legitimate username and password to make himself/herself a user.
+The user is the legitimate user of the database. A user corresponds to a unique username and has a password as a means of authentication. Before using the database, a person must first provide a legal (that is, stored in the database) user name and password to make himself a user.
Review comment:
himself/herself .. (Gender equity)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734935356
##########
File path: docs/UserGuide/API/Programming-TsFile-API.md
##########
@@ -113,7 +113,7 @@ Time-series data is considered as a sequence of quadruples. A quadruple is defin
sales number of some goods or the speed of a train at different times. As a traditional sensor (like a thermometer) also
takes a single measurement and produce a time-series, we will use measurement and sensor interchangeably below.
-* **device**: A device refers to an entity that takes several measurements (producing multiple time-series), e.g.,
+* **device**: A device is an entity that is taking several measurements (producing multiple timeseries), e.g.,
Review comment:
"is taking" -> "takes"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735624843
##########
File path: docs/UserGuide/Administration-Management/Administration.md
##########
@@ -116,7 +116,7 @@ At present, there is no conflicting privilege in IoTDB, so the real privileges o
It should be noted that if users have a privilege (corresponding to operation A) themselves and their roles contain the same privilege, then revoking the privilege from the users themselves alone can not prohibit the users from performing operation A, since it is necessary to revoke the privilege from the role, or revoke the role from the user. Similarly, revoking the privilege from the users's roles alone can not prohibit the users from performing operation A.
-At the same time, changes to roles are immediately reflected on all users who own the roles. For example, adding certain privileges to roles will immediately give all users who own the roles corresponding privileges, and deleting certain privileges will also deprive the corresponding users of the privileges (unless the users themselves have the privileges).
+At the same time, the modification of the role will be immediately reflected on all users who have the role. For example, adding certain privileges to roles will immediately give all users who have the roles corresponding privileges, and deleting certain privileges will also deprive the corresponding users of the privileges (unless the user have the privileges).
Review comment:
Got it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735617974
##########
File path: docs/UserGuide/Advanced-Features/UDF-User-Defined-Function.md
##########
@@ -68,7 +68,7 @@ The following table shows all the interfaces available for user implementation.
| `void transform(Row row, PointCollector collector) throws Exception` | This method is called by the framework. This data processing method will be called when you choose to use the `RowByRowAccessStrategy` strategy (set in `beforeStart`) to consume raw data. Input data is passed in by `Row`, and the transformation result should be output by `PointCollector`. You need to call the data collection method provided by `collector` to determine the output data. | Required to implement at least one `transform` method |
| `void transform(RowWindow rowWindow, PointCollector collector) throws Exception` | This method is called by the framework. This data processing method will be called when you choose to use the `SlidingSizeWindowAccessStrategy` or `SlidingTimeWindowAccessStrategy` strategy (set in `beforeStart`) to consume raw data. Input data is passed in by `RowWindow`, and the transformation result should be output by `PointCollector`. You need to call the data collection method provided by `collector` to determine the output data. | Required to implement at least one `transform` method |
| `void terminate(PointCollector collector) throws Exception` | This method is called by the framework. This method will be called once after all `transform` calls have been executed. In a single UDF query, this method will and will only be called once. You need to call the data collection method provided by `collector` to determine the output data. | Optional |
-| `void beforeDestroy() ` | This method is called by the framework after the last input data is processed, and will only be called once in the life cycle of each UDF instance. | Optional |
+| `void beforeDestroy() ` | End method of UDTF. This method is called by the framework after the last input data is processed, and will only be called once in the life cycle of each UDF instance. | Optional |
Review comment:
ok ,I changed it to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735644534
##########
File path: docs/UserGuide/API/Programming-TsFile-API.md
##########
@@ -225,10 +225,10 @@ A TsFile is generated by the following three steps and the complete code is give
* encoding: The data encoding.
- * compression: The data compression.
+ * compression: The data compression. Now supports UNCOMPRESSED and SNAPPY.
Review comment:
ok, I change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735678049
##########
File path: docs/UserGuide/API/Programming-Java-Native-API.md
##########
@@ -294,139 +304,13 @@ For examples of aligned timeseries and measurement template, you can refer to `e
+### Coding Examples
-### New Interfaces
Review comment:
Because there is no such part in the Chinese document, remove this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735647343
##########
File path: docs/UserGuide/API/Programming-TsFile-API.md
##########
@@ -113,7 +113,7 @@ Time-series data is considered as a sequence of quadruples. A quadruple is defin
sales number of some goods or the speed of a train at different times. As a traditional sensor (like a thermometer) also
takes a single measurement and produce a time-series, we will use measurement and sensor interchangeably below.
-* **device**: A device refers to an entity that takes several measurements (producing multiple time-series), e.g.,
+* **device**: A device is an entity that is taking several measurements (producing multiple timeseries), e.g.,
Review comment:
Got it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734934621
##########
File path: docs/Download/README.md
##########
@@ -69,7 +69,7 @@
Legacy version are available here: [https://archive.apache.org/dist/iotdb/](https://archive.apache.org/dist/iotdb/)
-**<font color=red>Attention</font>**:
+**<font color=red>Upgrade Notes</font>**:
Review comment:
upgrade guideline:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] krystal-xiao commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
krystal-xiao commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r735606283
##########
File path: docs/UserGuide/Advanced-Features/UDF-User-Defined-Function.md
##########
@@ -96,18 +96,18 @@ Please refer to the Javadoc for the usage of `UDFParameterValidator`.
### void beforeStart(UDFParameters parameters, UDTFConfigurations configurations) throws Exception
-This method is mainly used to customize UDTF. In this method, the user can do the following things:
+This method is mainly used to customize UDTF. The methods of beforestart do three functions:
Review comment:
ok ,I will change it back！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734935486
##########
File path: docs/UserGuide/API/Programming-TsFile-API.md
##########
@@ -225,10 +225,10 @@ A TsFile is generated by the following three steps and the complete code is give
* encoding: The data encoding.
- * compression: The data compression.
+ * compression: The data compression. Now supports UNCOMPRESSED and SNAPPY.
- * props: Properties for special data types.Such as `max_point_number` for `FLOAT` and `DOUBLE`, `max_string_length` for
- `TEXT`. Use as string pairs into a map such as ("max_point_number", "3").
+ * props: Properties for special data types.Such as `FLOAT` and `DOUBLE` can set `max_point_number` , `TEXT` can set `max_string_length`.
Review comment:
"`max_point_number` for `FLOAT` and `DOUBLE`" is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #4144: Update Configuration parameters
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #4144:
URL: https://github.com/apache/iotdb/pull/4144#discussion_r734935634
##########
File path: docs/UserGuide/Advanced-Features/UDF-User-Defined-Function.md
##########
@@ -23,19 +23,19 @@
# User Defined Function (UDF)
-IoTDB provides a variety of built-in functions to meet your computing needs, and you can also create user defined functions to meet more computing needs.
+UDF (User Defined Function) is a user-defined function.IoTDB provides a variety of built-in functions to meet your computing needs, and you can also create user defined functions to meet more computing needs.
Review comment:
"function.IoTDB" -> add a space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org