You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 03:54:36 UTC
[GitHub] [arrow] vibhatha opened a new pull request, #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
vibhatha opened a new pull request, #13605:
URL: https://github.com/apache/arrow/pull/13605
Initial draft for the `ignore_unknown_field` enabling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #13605:
URL: https://github.com/apache/arrow/pull/13605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
vibhatha commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1191642768
@pitrou Sure I will update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
vibhatha commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1192078447
> @vibhatha Well, can you make the PR description actually descriptive, instead of merely repeting the PR title? Thanks :-)
I will modify it 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #13605:
URL: https://github.com/apache/arrow/pull/13605#discussion_r926774650
##########
python/pyarrow/tests/test_substrait.py:
##########
@@ -66,11 +73,9 @@ def test_run_serialized_query(tmpdir):
}
"""
# TODO: replace with ipc when the support is finalized in C++
Review Comment:
This needs to be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
vibhatha commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1191646439
@pitrou Updated the description.
@westonpace removed the todo comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1183957827
https://issues.apache.org/jira/browse/ARROW-17066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
vibhatha commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1183962137
Need to figure out a better way to reprsent substrait plans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a diff in pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
westonpace commented on code in PR #13605:
URL: https://github.com/apache/arrow/pull/13605#discussion_r926767753
##########
python/pyarrow/tests/test_substrait.py:
##########
@@ -66,11 +73,9 @@ def test_run_serialized_query(tmpdir):
}
"""
# TODO: replace with ipc when the support is finalized in C++
Review Comment:
Is this comment still valid? It looks like this is IPC data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1191588809
@vibhatha Can you update the PR description since it will end up as the commit message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] richtia commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
richtia commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1183975779
I tried your branch, but since it also has the latest substrait now, i'm actually hitting some other issues, that Weston will be fixing. ARROW-15582/ARROW-15538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1191663549
@vibhatha Well, can you make the PR description actually descriptive, instead of merely repeting the PR title? Thanks :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
vibhatha commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1183957184
cc @westonpace
Not exactly sure if this is the expected fix. I may need some help to figure out a better test case too.
Please advise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1183957836
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] richtia commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
richtia commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1183967462
I'll try to test it out using your branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1183957842
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
vibhatha commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1192082020
@pitrou could you please check the updated description? Is it okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1191663750
i.e., explain _why_ this is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13605: ARROW-17066: [C++][Python][Substrait] "ignore_unknown_fields" should be specified when converting JSON to binary
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13605:
URL: https://github.com/apache/arrow/pull/13605#issuecomment-1193115556
Benchmark runs are scheduled for baseline = 32016b1ade710a6585e2c1a1023d2e44a55420a8 and contender = 791e5bd6e413c193a214237d042f4f721ccc0976. 791e5bd6e413c193a214237d042f4f721ccc0976 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/df449362380747b3831f621e668dcc99...0a8e191e1b044ff38fafb62ced28bffe/)
[Failed :arrow_down:0.1% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/85afc15863c644e1bbe9ba8928574320...e08da9d4a39b45b19f77abe80bb2ef77/)
[Failed :arrow_down:0.32% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/edd97863dbae448b9e86e3f6311b2317...6cfbc15cdf0a4dfc9ea5fd36547185bc/)
[Finished :arrow_down:0.25% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f73b196c909241eaa0e7ad1f0592970d...44b606b7eaa94f73987d7fdfc5ec7451/)
Buildkite builds:
[Failed] [`791e5bd6` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1179)
[Failed] [`791e5bd6` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1191)
[Failed] [`791e5bd6` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1173)
[Finished] [`791e5bd6` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1193)
[Failed] [`32016b1a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1178)
[Failed] [`32016b1a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1190)
[Failed] [`32016b1a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1172)
[Finished] [`32016b1a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1192)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org