[jira] [Commented] (S2GRAPH-68) Refactor write-write conflict resolving logic

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305183#comment-15305183 ] 

ASF GitHub Bot commented on S2GRAPH-68:
---------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/53

    [S2GRAPH-68]: Refactor write-write conflict resolving logic.

    + more comments and simplified code.
    + remove excessive re-fetch on every retry from partial failure.
    + remove Thread.sleep between retry from partial failure.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-68

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 607bbb244a6686e5fa9654761d7b66d8b9e9b60b
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-05-28T05:20:09Z

    [S2GRAPH-68]: Refactor write-write conflict resolving logic.
    + more comments and simplified code.
    + remove excessive re-fetch on every retry from partial failure.
    + remove Thread.sleep between retry from partial failure.

----


> Refactor write-write conflict resolving logic
> ---------------------------------------------
>
>                 Key: S2GRAPH-68
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-68
>             Project: S2Graph
>          Issue Type: Improvement
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>              Labels: consistency, write
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Current implementation for resolving write-write conflict on snapshotEdge is overwhelmingly complicated, so I am suggesting refactor this to make it easy to understand.
> Current master test cases failed with positive fail probability for RPC(hbase.fail.prob=0.01).
> I can reproduce it by running `sbt "project s2core" -Dconfig.file=s2rest_play/conf/test.conf test`.
> We can think this problem as critical section problem. Multiple thread that want to mutate same SnapshotEdge can only proceed one-by-one to keep consistent view on related IndexEdge. To achieve this, we are storing extra data on SnapshotEdge. 
> Details are on [gitbook|https://steamshon.gitbooks.io/s2graph-book/content/request_state_diagram.html].
> I think following 3 things would be expected output after resolving this issue.
> 1. more comments and simplified code.
> 2. remove excessive re-fetch on every retry from partial failure. since it is guaranteed that only one thread can proceed at a time, re-fetch is not necessary.
> 3. remove Thread.sleep between retry from partial failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)