[GitHub] [airflow] uranusjr commented on a diff in pull request #28757: Initial draft of composable timetables

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #28757:
URL: https://github.com/apache/airflow/pull/28757#discussion_r1063264535


##########
airflow/timetables/composable.py:
##########
@@ -0,0 +1,124 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from typing import Any
+
+from pendulum import DateTime
+
+from airflow.timetables._cron import CronMixin
+from airflow.timetables.base import DagRunInfo, DataInterval, TimeRestriction, Timetable
+from airflow.timetables.strategy_protocol import IntervalStrategy, ManualStrategy, RunStrategy
+
+
+def compose_timetable(
+    run_strategy_cls: type[RunStrategy],
+    interval_strategy_cls: type[IntervalStrategy],
+    manual_strategy_cls: type[ManualStrategy],
+):

Review Comment:
   Ikind of feel this method is a bit redundant and can simply be implemented with a class…?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org