You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Daniel Pitts (Updated) (JIRA)" <ji...@apache.org> on 2011/10/15 20:39:11 UTC
[jira] [Updated] (OGNL-27) Move "toString" implementations into
visitor pattern.
[ https://issues.apache.org/jira/browse/OGNL-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Pitts updated OGNL-27:
-----------------------------
Attachment: to_string_visitor1.patch
This patch replaces the mishmash of toString methods in the AST classes.
> Move "toString" implementations into visitor pattern.
> -----------------------------------------------------
>
> Key: OGNL-27
> URL: https://issues.apache.org/jira/browse/OGNL-27
> Project: OGNL
> Issue Type: New Feature
> Reporter: Daniel Pitts
> Attachments: to_string_visitor1.patch
>
>
> Using the Visitor pattern allows for a cleaner implementation of toString().
> I have a patch which will remove toString() from all AST classes, and replace it with a single toString() in "SimpleNode" which delegates to a ToStringVisitor to build the String efficiently.
> This patch can also be used as an example of how to move other business logic out of the AST classes into their own visitor classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira