You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by fmartelli <no...@github.com> on 2015/04/09 10:16:23 UTC
[jclouds-labs] [JCLOUDS-879] fixed (#163)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/163
-- Commit Summary --
* [JCLOUDS-879] fixed
-- File Changes --
M azurecompute/src/main/java/org/jclouds/azurecompute/AzureComputeApi.java (11)
A azurecompute/src/main/java/org/jclouds/azurecompute/binders/ReservedIPAddressParamsToXML.java (48)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/ReservedIPAddress.java (152)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/ReservedIPAddressParams.java (104)
M azurecompute/src/main/java/org/jclouds/azurecompute/domain/ServiceCertificateParams.java (4)
A azurecompute/src/main/java/org/jclouds/azurecompute/features/ReservedIPAddressApi.java (107)
A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListReservedIPAddressHandler.java (78)
A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ReservedIPAddressHandler.java (103)
A azurecompute/src/test/java/org/jclouds/azurecompute/features/ReservedIPAddressApiLiveTest.java (92)
A azurecompute/src/test/java/org/jclouds/azurecompute/features/ReservedIPAddressApiMockTest.java (131)
A azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListReservedIPAddressHandlerTest.java (65)
A azurecompute/src/test/java/org/jclouds/azurecompute/xml/ReservedIPAddressHandlerTest.java (47)
A azurecompute/src/test/resources/listreservedipaddress.xml (20)
A azurecompute/src/test/resources/reservedipaddress.xml (10)
A azurecompute/src/test/resources/reservedipaddressparams.xml (1)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/163.patch
https://github.com/jclouds/jclouds-labs/pull/163.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by fmartelli <no...@github.com>.
@nacx, fixed as required.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163#issuecomment-91242787
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -113,6 +113,17 @@ public static ExternalEndpoint inboundUdpToLocalPort(final int port, final int l
> @Nullable
> public abstract String virtualNetworkName();
>
> + /**
> + * Optional. Specifies the name of a reserved IP address that is to be assigned to the deployment. You must run
> + * Create Reserved IP Address before you can assign the address to the deployment using this element.
> + *
> + * The ReservedIPName element is only available using version 2014-05-01 or higher.
> + *
> + * @return reserved IP.
> + */
> + @Nullable
> + public abstract String reservedIPName();
It could be also convenient to annotate this with [SinceApiVersion](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/rest/annotations/SinceApiVersion.java).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163/files#r28062793
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by Ignasi Barrera <no...@github.com>.
Should #161 be closed then?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163#issuecomment-91238249
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by Ignasi Barrera <no...@github.com>.
lgtm! There are just a few minor comments. Nice job @fmartelli!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163#issuecomment-91240391
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by Ignasi Barrera <no...@github.com>.
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/11ae78af) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f0a11c96). Thanks @fmartelli!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163#issuecomment-91253454
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by Ignasi Barrera <no...@github.com>.
Nice! can you squash the commits, and amend a bit the commit message so it is more meaningful? I'll merge this then, if it can be merged before #161.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163#issuecomment-91246384
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by Ignasi Barrera <no...@github.com>.
Closed #163.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163#event-277249225
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by Ignasi Barrera <no...@github.com>.
> +import static org.testng.Assert.assertTrue;
> +
> +import com.google.common.base.Predicate;
> +import java.util.logging.Level;
> +import java.util.logging.Logger;
> +
> +import org.jclouds.azurecompute.domain.ReservedIPAddress;
> +import org.jclouds.azurecompute.domain.ReservedIPAddress.State;
> +import org.jclouds.azurecompute.domain.ReservedIPAddressParams;
> +import org.jclouds.azurecompute.internal.AbstractAzureComputeApiLiveTest;
> +import org.jclouds.util.Predicates2;
> +import org.testng.Assert;
> +import org.testng.annotations.AfterClass;
> +import org.testng.annotations.Test;
> +
> +@Test(groups = "live", testName = "ServiceCertificatesApiLivTest", singleThreaded = true)
Change test name to `ReservedIPAddressApiLiveTest`.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163/files#r28063068
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -107,6 +107,9 @@
>
> final String storageAccountName = templateOptions.getStorageAccountName().get();
> final String virtualNetworkName = templateOptions.getVirtualNetworkName().get();
> + final String reservedIPAddress = templateOptions.getReservedIPName().isPresent()
> + ? templateOptions.getReservedIPName().get()
> + : null;
Change to `final String reservedIPAddress = templateOptions.getReservedIPName().orNull();`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163/files#r28062659
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by fmartelli <no...@github.com>.
done! Yes, you can merge it before.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163#issuecomment-91247056
Re: [jclouds-labs] [JCLOUDS-879] fixed (#163)
Posted by fmartelli <no...@github.com>.
@nacx, this fix is ready to be reviewed.
Please, let me know if you need more actions from my side.
Thanks in advance.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/163#issuecomment-91212434