You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mingyen066 (via GitHub)" <gi...@apache.org> on 2025/03/14 11:46:19 UTC
[PR] KAFKA-17715: Remove argument force_use_zk_connection from e2e [kafka]
mingyen066 opened a new pull request, #19209:
URL: https://github.com/apache/kafka/pull/19209
Since no E2E tests are using the argument `force_use_zk_connection`, remove it from e2e test.
Modified from: https://github.com/apache/kafka/pull/17465
Co-authored-by: @mingdaoy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17715: Remove argument force_use_zk_connection from kafka_acls_cmd_with_optional_security_settings [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #19209:
URL: https://github.com/apache/kafka/pull/19209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17715: Remove argument force_use_zk_connection from kafka_acls_cmd_with_optional_security_settings [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19209:
URL: https://github.com/apache/kafka/pull/19209#discussion_r2192945295
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -1346,34 +1340,29 @@ def alter_message_format(self, topic, msg_format_version, node=None):
cmd = fix_opts_for_new_jvm(node)
cmd += "%s --entity-name %s --entity-type topics --alter --add-config message.format.version=%s" % \
- (self.kafka_configs_cmd_with_optional_security_settings(node, force_use_zk_connection), topic, msg_format_version)
+ (self.kafka_configs_cmd_with_optional_security_settings(node, force_use_zk_connection), topic, msg_format_version)
Review Comment:
please remove this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17715: Remove argument force_use_zk_connection from e2e [kafka]
Posted by "mingyen066 (via GitHub)" <gi...@apache.org>.
mingyen066 commented on PR #19209:
URL: https://github.com/apache/kafka/pull/19209#issuecomment-2745971624
@frankvicky @m1a2st
I pasted the test results that passed into the PR body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17715: Remove argument force_use_zk_connection from e2e [kafka]
Posted by "mingyen066 (via GitHub)" <gi...@apache.org>.
mingyen066 commented on PR #19209:
URL: https://github.com/apache/kafka/pull/19209#issuecomment-2745411136
@m1a2st Thanks for spotting the failed test. It turns out we cannot remove the force_use_zk_connection in kafka_topics_cmd_with_optional_security_settings because kafka-topics.sh does not support --bootstrap-server in 2.1 and 2.2.
https://github.com/apache/kafka/blob/5d2bfb4151700000fc5ec22918ecd3cecb5178a5/tests/kafkatest/version.py#L68-L69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org