You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/06/24 08:01:26 UTC

[GitHub] zeppelin pull request #1079: Prevent menubar hide notebook title and control...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/1079

    Prevent menubar hide notebook title and control buttons depending on screen size

    ### What is this PR for?
    Prevent menubar hide notebook title and control buttons, depending on screen size
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - Make search input box smaller
    
    ### How should this be tested?
    Resize your browser
    
    ### Screenshots (if appropriate)
    before
    ![menubar_before](https://cloud.githubusercontent.com/assets/1540981/16331737/0ea27b88-39a7-11e6-8db5-e14326aecbaf.gif)
    after
    ![menubar_after](https://cloud.githubusercontent.com/assets/1540981/16331742/19ea0cc2-39a7-11e6-9535-16c5d7926694.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin change_search_input_size

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1079
    
----
commit ffb94907231763abd77e0c2715094bcf38bdcdf0
Author: Lee moon soo <mo...@apache.org>
Date:   2016-06-24T07:58:08Z

    Change search input box size

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1079: Prevent menubar hide notebook title and control button...

Posted by AhyoungRyu <gi...@git.apache.org>.

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1079
  
    Better! LGTM \U0001f44d 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1079: Prevent menubar hide notebook title and control button...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1079
  
    Merging this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1079: Prevent menubar hide notebook title and control button...

Posted by astroshim <gi...@git.apache.org>.

Github user astroshim commented on the issue:

    https://github.com/apache/zeppelin/pull/1079
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1079: Prevent menubar hide notebook title and control...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1079


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1079: Prevent menubar hide notebook title and control button...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1079
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---