You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/09 02:59:27 UTC
[GitHub] [flink] zoudaokoulife commented on a change in pull request #10489:
[FLINK-15134][client] Delete temporary files created in YarnClusterDescriptor
zoudaokoulife commented on a change in pull request #10489: [FLINK-15134][client] Delete temporary files created in YarnClusterDescriptor
URL: https://github.com/apache/flink/pull/10489#discussion_r355244905
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -867,27 +870,28 @@ private ApplicationReport startAppMaster(
TaskManagerOptions.TOTAL_PROCESS_MEMORY,
clusterSpecification.getTaskManagerMemoryMB() + "m");
- // Upload the flink configuration
- // write out configuration file
- File tmpConfigurationFile = File.createTempFile(appId + "-flink-conf.yaml", null);
- tmpConfigurationFile.deleteOnExit();
- BootstrapTools.writeConfiguration(configuration, tmpConfigurationFile);
+ {
+ // Upload the flink configuration
+ // write out configuration file
+ File tmpConfigurationFile = File.createTempFile(appId + "-flink-conf.yaml", null);
+ tmpConfigurationFile.deleteOnExit();
Review comment:
Since it has been manually deleted，i think "tmpConfigurationFile.deleteOnExit();" is not necessary，
and it's better to contain in finally{}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services