Request: Can we add the platform to cordova-js commits?

[Becky Gibson <gi...@gmail.com>]

I often review the checkins in incubator-cordova-js to keep tabs on what is
changing.   I am selfishly, generally only interested in global or iOS
related commits.  While I know what platforms most committers generally
work on, it would nice be to be able to tell from the commit comment what
platform was affected.  Thus, I'm asking if people will include the
platform in the first line of the comment for commits to
incubator-cordova-js (or at least in one of the comments in a group of
commits).  This would also be helpful in phonegap-plugins.

thanks,
-becky

Re: Request: Can we add the platform to cordova-js commits?

[Andrew Grieve <ag...@chromium.org>]

I'm guilty of doing a JS commit this week and I got annoyed myself when
looking in the history and it didn't say the platform in the message. Might
be worth using some git hooks for this purpose:

http://git-scm.com/book/en/Customizing-Git-Git-Hooks

Even if we didn't use a hook to enforce the [label] structure, we can use
one to set the default commit message and have it include a reminder to
mention the affected platforms.


On Fri, Aug 17, 2012 at 6:32 PM, Jesse <pu...@gmail.com> wrote:

> Not worth enforcing, IMHO, but it is nice if you do it.
> How does this relate to topic branches?
>
> On Fri, Aug 17, 2012 at 2:35 PM, Michael Brooks <michael@michaelbrooks.ca
> >wrote:
>
> > One common approach is to prefix each commit message with the category.
> >
> > For the Hello World Cordova app, I've been using the following: [app],
> > [test], and [doc].
> >
> > Examples of the usage are:
> >     $ commit -am "[app] Refactor the JavaScript."
> >     $ commit -am "[test] Add deviceready test case."
> >     $ commit -am "[doc] Update README.md with tagging details."
> >
> > The approach can be applied to cordova-js, but for platforms: [android],
> > [bada], [blackberry], [common], [ios], [webos], [tizen], [wp7], whatever.
> >     $ commit -am "[common] Refactored Geolocation"
> >     $ commit -am "[wp7] Did something Windows Phone specific."
> >
> > Michael
> >
> > On Fri, Aug 17, 2012 at 12:30 PM, Becky Gibson <gibson.becky@gmail.com
> > >wrote:
> >
> > > I often review the checkins in incubator-cordova-js to keep tabs on
> what
> > is
> > > changing.   I am selfishly, generally only interested in global or iOS
> > > related commits.  While I know what platforms most committers generally
> > > work on, it would nice be to be able to tell from the commit comment
> what
> > > platform was affected.  Thus, I'm asking if people will include the
> > > platform in the first line of the comment for commits to
> > > incubator-cordova-js (or at least in one of the comments in a group of
> > > commits).  This would also be helpful in phonegap-plugins.
> > >
> > > thanks,
> > > -becky
> > >
> >
>
>
>
> --
> @purplecabbage
> risingj.com
>

Re: Request: Can we add the platform to cordova-js commits?

[Jesse <pu...@gmail.com>]

Not worth enforcing, IMHO, but it is nice if you do it.
How does this relate to topic branches?

On Fri, Aug 17, 2012 at 2:35 PM, Michael Brooks <mi...@michaelbrooks.ca>wrote:

> One common approach is to prefix each commit message with the category.
>
> For the Hello World Cordova app, I've been using the following: [app],
> [test], and [doc].
>
> Examples of the usage are:
>     $ commit -am "[app] Refactor the JavaScript."
>     $ commit -am "[test] Add deviceready test case."
>     $ commit -am "[doc] Update README.md with tagging details."
>
> The approach can be applied to cordova-js, but for platforms: [android],
> [bada], [blackberry], [common], [ios], [webos], [tizen], [wp7], whatever.
>     $ commit -am "[common] Refactored Geolocation"
>     $ commit -am "[wp7] Did something Windows Phone specific."
>
> Michael
>
> On Fri, Aug 17, 2012 at 12:30 PM, Becky Gibson <gibson.becky@gmail.com
> >wrote:
>
> > I often review the checkins in incubator-cordova-js to keep tabs on what
> is
> > changing.   I am selfishly, generally only interested in global or iOS
> > related commits.  While I know what platforms most committers generally
> > work on, it would nice be to be able to tell from the commit comment what
> > platform was affected.  Thus, I'm asking if people will include the
> > platform in the first line of the comment for commits to
> > incubator-cordova-js (or at least in one of the comments in a group of
> > commits).  This would also be helpful in phonegap-plugins.
> >
> > thanks,
> > -becky
> >
>



-- 
@purplecabbage
risingj.com

Re: Request: Can we add the platform to cordova-js commits?

[Michael Brooks <mi...@michaelbrooks.ca>]

One common approach is to prefix each commit message with the category.

For the Hello World Cordova app, I've been using the following: [app],
[test], and [doc].

Examples of the usage are:
    $ commit -am "[app] Refactor the JavaScript."
    $ commit -am "[test] Add deviceready test case."
    $ commit -am "[doc] Update README.md with tagging details."

The approach can be applied to cordova-js, but for platforms: [android],
[bada], [blackberry], [common], [ios], [webos], [tizen], [wp7], whatever.
    $ commit -am "[common] Refactored Geolocation"
    $ commit -am "[wp7] Did something Windows Phone specific."

Michael

On Fri, Aug 17, 2012 at 12:30 PM, Becky Gibson <gi...@gmail.com>wrote:

> I often review the checkins in incubator-cordova-js to keep tabs on what is
> changing.   I am selfishly, generally only interested in global or iOS
> related commits.  While I know what platforms most committers generally
> work on, it would nice be to be able to tell from the commit comment what
> platform was affected.  Thus, I'm asking if people will include the
> platform in the first line of the comment for commits to
> incubator-cordova-js (or at least in one of the comments in a group of
> commits).  This would also be helpful in phonegap-plugins.
>
> thanks,
> -becky
>