You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "wilx (via GitHub)" <gi...@apache.org> on 2026/07/28 10:52:08 UTC
[PR] [MASSEMBLY-1001] Include attachments from POM modules [maven-assembly-plugin]
wilx opened a new pull request, #1344:
URL: https://github.com/apache/maven-assembly-plugin/pull/1344
Fixes #1208.
POM-packaged reactor modules are currently removed from a module set before
`attachmentClassifier` is examined. This prevents the assembly from using a
matching attached artifact even though POM projects can legitimately produce
classified artifacts.
This change retains POM modules when a classifier is requested and lets the
existing attachment lookup select the artifact or report a missing attachment.
POM modules remain filtered when the module set selects main project artifacts,
preserving the behavior introduced for structural reactor projects without a
main binary.
The regression test builds a POM-packaged reactor module that attaches a
`site`-classified JAR and verifies that a sibling assembly module can select and
unpack it.
Validation:
- Maven 3.9.16 with JDK 21: `mvn -Prun-its clean verify` — 268 unit tests and
151 Invoker builds passed.
- Maven 4.0.0-rc-5 with JDK 21: focused MASSEMBLY-1001 Invoker test passed.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in other changes.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MASSEMBLY-1001] Include attachments from POM modules [maven-assembly-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #1344:
URL: https://github.com/apache/maven-assembly-plugin/pull/1344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MASSEMBLY-1001] Include attachments from POM modules [maven-assembly-plugin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1344:
URL: https://github.com/apache/maven-assembly-plugin/pull/1344#issuecomment-5178282524
@elharo Please assign appropriate label to PR according to the type of change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org