[GitHub] [airflow] brki commented on pull request #25710: postgres provider: use non-binary psycopg2

[GitBox <gi...@apache.org>]

brki commented on PR #25710:
URL: https://github.com/apache/airflow/pull/25710#issuecomment-1221268038

   OK. Thanks for the explanation! I'll adjust it later.
   
   On Sat, 20 Aug 2022, 11:22 Jarek Potiuk ***@***.***> wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In docs/apache-airflow-providers-postgres/index.rst
   > <https://github.com/apache/airflow/pull/25710#discussion_r950673413>:
   >
   > > @@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres
   >  `PostgreSQL <https://www.postgresql.org/>`__
   >
   >
   > -Release: 5.2.0
   > +Release: 6.0.0
   >
   > This is not what we consider as breaking. Dependency changes are not
   > introducing. Our SemVer rules state (see readme)
   >
   > Airflow: SemVer rules apply to core airflow only (excludes any changes to
   > providers). Changing limits for versions of Airflow dependencies is not a
   > breaking change on its own.
   >
   > And while this is not changing the version but other 'variant' of the same
   > dependency, this only affect how you install airflow. And it is not
   > breaking the 'use' of Airflow which is the important factor for
   > breaking/non breaking decision.
   >
   > The main thing here that changes that are only affecting the way how you
   > install Airfloe are not really 'breaking' any user code or ways how you use
   > airflow. If for any reason you cannot install Airflow new version, you just
   > cannot install it and you don't break anything. Once you installed it, it
   > works without changes. So it does not break anything.
   >
   > If you follow the logic of 'dependencies are breaking changed' then it
   > basically would mean than any release where any dependency change is
   > breaking - because it might cause troubles when installing Airflow or
   > providers.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/airflow/pull/25710#discussion_r950673413>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAFKHGHUKE2TMV6P6DHE6ALV2CPUTANCNFSM56PS4F6A>
   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org