You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@annotator.apache.org by GitBox <gi...@apache.org> on 2021/10/12 11:14:16 UTC

[GitHub] [incubator-annotator] Treora opened a new pull request #116: Add scripts to (semi)automate release steps

Treora opened a new pull request #116:
URL: https://github.com/apache/incubator-annotator/pull/116


   These are roughly the commands from our [Creating a Release](https://github.com/apache/incubator-annotator/wiki/Creating-a-Release) and [Testing a Source Release](https://github.com/apache/incubator-annotator/wiki/Testing-a-Source-Release) wiki pages, with the idea to make these procedures easier for a next release.
   
   @tilgovi & @BigBlueHat would you like to improve these scripts, or take another approach to it? Consider it just a draft; feel free to modify substantially or ignore this attempt altogether.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@annotator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-annotator] Treora commented on pull request #116: Add scripts to (semi)automate release steps

Posted by GitBox <gi...@apache.org>.
Treora commented on pull request #116:
URL: https://github.com/apache/incubator-annotator/pull/116#issuecomment-1083812835


   I added a commit that downloads RAT, removes comments, removes the sleep pauses too. But I get an error when running this, which looks unrelated to the current change:
   
   ```
   $ VERSION=0.2.0 RC=1 ../incubator-annotator/scripts/obtain-rc.sh
   …
   $ VERSION=0.2.0 RC=1 ../incubator-annotator/scripts/verify-rc.sh
   …
   tar: apache-annotator-0.2.0-incubating/.git/objects/pack/pack-4e188f5a157612fce8b35a7c799ff1c71b2af004.idx: Cannot open: Permission denied
   tar: apache-annotator-0.2.0-incubating/.git/objects/pack/pack-4e188f5a157612fce8b35a7c799ff1c71b2af004.pack: Cannot open: Permission denied
   ```
   
   Could you perhaps check if it works for you, @tilgovi (or anyone)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@annotator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-annotator] Treora commented on pull request #116: Add scripts to (semi)automate release steps

Posted by GitBox <gi...@apache.org>.
Treora commented on pull request #116:
URL: https://github.com/apache/incubator-annotator/pull/116#issuecomment-962694567


   > This is a great start! I'll check out the branch locally, see if there are any tweaks to make, and maybe try to push up changes to make the verify command interactive. How does that sound?
   
   Sounds good! Sorry for my lack of reply before. As said, feel free to build on this or deviate from it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@annotator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-annotator] tilgovi commented on pull request #116: Add scripts to (semi)automate release steps

Posted by GitBox <gi...@apache.org>.
tilgovi commented on pull request #116:
URL: https://github.com/apache/incubator-annotator/pull/116#issuecomment-945211415


   This is a great start! I'll check out the branch locally, see if there are any tweaks to make, and maybe try to push up changes to make the verify command interactive. How does that sound?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@annotator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #116: Add scripts to (semi)automate release steps

Posted by GitBox <gi...@apache.org>.
tilgovi commented on a change in pull request #116:
URL: https://github.com/apache/incubator-annotator/pull/116#discussion_r747279515



##########
File path: scripts/verify-rc.sh
##########
@@ -0,0 +1,52 @@
+set -e
+
+#VERSION=0.2.0

Review comment:
       We can remove these comments.

##########
File path: scripts/verify-rc.sh
##########
@@ -0,0 +1,52 @@
+set -e
+
+#VERSION=0.2.0
+#RC=1
+
+if [ -z "$VERSION" ] || [ -z "$RC" ]
+then
+  echo "First set the VERSION and RC environment variables."
+  exit 1
+fi
+
+gpg --verify apache-annotator-*.tar.gz.asc
+
+sleep 5
+
+sha256sum --check apache-annotator-*.tar.gz.sha256
+sha512sum --check apache-annotator-*.tar.gz.sha512
+
+sleep 5
+
+tar xzf apache-annotator-$VERSION-rc.$RC-incubating.tar.gz
+cd apache-annotator-$VERSION-incubating
+
+git remote show origin
+
+sleep 5
+
+git fetch --unshallow origin tag v$VERSION-rc.$RC
+
+git describe
+
+sleep 5
+
+git status --ignored
+
+sleep 5
+
+# Expects Apache RAT 0.13 jar to be present in home directory
+# wget https://dlcdn.apache.org/creadur/apache-rat-0.13/apache-rat-0.13-bin.zip
+# unzip apache-rat-0.13-bin.zip
+java -jar ~/apache-rat-0.13.jar -E .ratignore -d .

Review comment:
       Do you think we should just download rat here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@annotator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org