You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/21 19:25:01 UTC

[GitHub] [flink] syhily opened a new pull request, #20336: [FLINK-28609][Connector/Pulsar] PulsarSchema didn't get properly serialized

syhily opened a new pull request, #20336:
URL: https://github.com/apache/flink/pull/20336

   ## What is the purpose of the change
   
   PulsarSchema uses readObject and writeObject for customized serialization. But the ObjectInputStream only accepts the first 1018 bytes. We had to remove the custom logic and didn't override the default mechanism.
   
   ## Brief change log
   
   1. Add a test for reproducing the bug (Big schema serialization issue)
   2. Change the serialization logic in `PulsarSchema`
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - `PulsarSchemaTest.largeAvroSchemaSerialization`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (yes)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20336: [FLINK-28609][Connector/Pulsar] PulsarSchema didn't get properly serialized

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20336:
URL: https://github.com/apache/flink/pull/20336#issuecomment-1191861082

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5c61f56d410045690e698a9d15a48f7039580eca",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5c61f56d410045690e698a9d15a48f7039580eca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5c61f56d410045690e698a9d15a48f7039580eca UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily closed pull request #20336: [FLINK-28609][Connector/Pulsar] PulsarSchema didn't get properly serialized

Posted by GitBox <gi...@apache.org>.
syhily closed pull request #20336: [FLINK-28609][Connector/Pulsar] PulsarSchema didn't get properly serialized
URL: https://github.com/apache/flink/pull/20336


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org