You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "rechardguo (via GitHub)" <gi...@apache.org> on 2023/05/08 14:56:21 UTC
[GitHub] [skywalking-java] rechardguo opened a new pull request, #527: to fix bug #[10770] by support jboss can config skywalking-agent and start correct
rechardguo opened a new pull request, #527:
URL: https://github.com/apache/skywalking-java/pull/527
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Fix <10770>
- [x] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#discussion_r1188630138
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/boot/AgentPackagePath.java:
##########
@@ -50,6 +50,9 @@ private static File findPath() throws AgentPackageNotFoundException {
String classResourcePath = AgentPackagePath.class.getName().replaceAll("\\.", "/") + ".class";
URL resource = ClassLoader.getSystemClassLoader().getResource(classResourcePath);
+ if (resource == null) {
+ resource = AgentPackagePath.class.getClassLoader().getResource(classResourcePath);
+ }
Review Comment:
```suggestion
URL resource = AgentPackagePath.class.getClassLoader().getResource(classResourcePath);
```
I am wondering, is this enough? Why do we need a fail-back? I think in most cases, `AgentPackagePath` should be loaded by the expected classloader(appclassloader or moduleclassloader)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] rechardguo commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "rechardguo (via GitHub)" <gi...@apache.org>.
rechardguo commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1540239014
@wu-sheng
How to update change logs?
Is it add 8.17.0 comment similar to 8.16.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1540158882
> This ut simulate jboss use moduleClassloader load agent code and then get path null
Below hightlight will be null
This doesn't need to be proved. Once the `AgentPackagePath` is loaded by another class loader(Not ClassLoader.getSystemClassLoader). The return would be NULL for sure.
We don't need a test case for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1538533722
Yes, once it is open source, it is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#discussion_r1188060392
##########
apm-sniffer/apm-agent-test/src/test/java/org/apache/skywalking/apm/agent/core/boot/AgentPackagePathTest.java:
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.boot;
+
+import org.junit.Test;
+
+import java.io.File;
+import java.io.IOException;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.net.URI;
+import java.net.URL;
+import java.net.URLClassLoader;
+import java.util.Properties;
+
+/**
+ * this test case is to verify the fix of bug
+ * https://github.com/apache/skywalking/issues/10770
+ */
+public class AgentPackagePathTest {
+
+ @Test
+ public void testGetPathNotNull() throws ClassNotFoundException, IllegalAccessException, NoSuchMethodException, InvocationTargetException, IOException {
Review Comment:
I am confused about this UT. How could a UT verify class loader issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] rechardguo commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "rechardguo (via GitHub)" <gi...@apache.org>.
rechardguo commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1540035401
@wu-sheng
1. This seperator is different between linux and window
i reproduce in my local wsl2.
2. This ut simulate jboss use moduleClassloader load agent code and then get path null
Below hightlight will be null
That is why i construct a urlClassloader and use that get path
I add one more null check , and if true to use AgentPackagePath.class.getClassLoader().getResource(classResourcePath).
the UT is actually check this code.
3. Why i put ut in apm-agent-test module but not apm-agent-core because if do so,
URL resource = ClassLoader.getSystemClassLoader().getResource(classResourcePath) will always not null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] rechardguo commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "rechardguo (via GitHub)" <gi...@apache.org>.
rechardguo commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1540276145
@wu-sheng Thanks for your patient. I remove test case and update change log(not sure if properly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#discussion_r1188059728
##########
apm-sniffer/apm-agent-test/pom.xml:
##########
@@ -0,0 +1,51 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.skywalking</groupId>
+ <artifactId>java-agent-sniffer</artifactId>
+ <version>8.16.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>apm-agent-test</artifactId>
Review Comment:
What is this new module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] lujiajing1126 commented on pull request #527: to fix bug #[10770] by support jboss can config skywalking-agent and start correct
Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1538517721
According to the https://github.com/apache/skywalking/issues/10770#issuecomment-1538276679
You should provide an E2E case to verify this behavior. For example, use JBoss as the servlet container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1539306973
> Should be path seperator not set properly(use File.separator instead of hardcode /). I will change and verify in linux.
I don't think so. Our agent works on Window AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] rechardguo commented on a diff in pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "rechardguo (via GitHub)" <gi...@apache.org>.
rechardguo commented on code in PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#discussion_r1188646875
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/boot/AgentPackagePath.java:
##########
@@ -50,6 +50,9 @@ private static File findPath() throws AgentPackageNotFoundException {
String classResourcePath = AgentPackagePath.class.getName().replaceAll("\\.", "/") + ".class";
URL resource = ClassLoader.getSystemClassLoader().getResource(classResourcePath);
+ if (resource == null) {
+ resource = AgentPackagePath.class.getClassLoader().getResource(classResourcePath);
+ }
Review Comment:
Actually i want to change as that. But to compatible with the old funtion, I am not quite sure the very beginning design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1538588020
> AgentPackagePathTest.testGetPathNotNull:53 Runtime apm-agent-test path not found
It seems your codes break the UT. Please recheck and fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] rechardguo commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "rechardguo (via GitHub)" <gi...@apache.org>.
rechardguo commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1539302310
Should be path seperator not set properly(use File.separator instead of hardcode /). I will change and verify in linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1540202069
1. Remove new module you created.
2. Update the changes log by following the PR template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1540055905
> This seperator is different between linux and window
They are definitely different. But I don't think it does matter. Otherwise, agent wouldn't work on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#discussion_r1188724742
##########
CHANGES.md:
##########
@@ -14,6 +14,7 @@ Release Notes.
* [Chore] Exclude org.checkerframework:checker-qual and com.google.j2objc:j2objc-annotations
* [Chore] Exclude proto files in the generated jar
* Fix Jedis-2.x plugin can not get host info in jedis 3.3.x+
+* Change AgentPackagePath#findPath() to get AgentPackagePath url by AgentPackagePath.class.getClassLoader()
Review Comment:
```suggestion
* Change the classloader to locate the agent path in AgentPackagePath, from `SystemClassLoader` to AgentPackagePath's loader.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] lujiajing1126 commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1538530060
Seems JBoss (Wildfly) is using LGPL v2.1 (https://www.apache.org/legal/resolved.html#category-x). Can we use this for testing purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #527:
URL: https://github.com/apache/skywalking-java/pull/527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1540264556
Currently, it is 8.16.0. You just need to add a line of change description here.
Once 8.16.0 is released, this file would be updated to 8.17.0 by the release manager. You don't need to bother about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1540251413
Add what you changed and fixed as a sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #527: Support agent running in the JBoss relative with its ModuleClassloader.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#discussion_r1188649189
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/boot/AgentPackagePath.java:
##########
@@ -50,6 +50,9 @@ private static File findPath() throws AgentPackageNotFoundException {
String classResourcePath = AgentPackagePath.class.getName().replaceAll("\\.", "/") + ".class";
URL resource = ClassLoader.getSystemClassLoader().getResource(classResourcePath);
+ if (resource == null) {
+ resource = AgentPackagePath.class.getClassLoader().getResource(classResourcePath);
+ }
Review Comment:
I think it should be compatible. Please change and remove all your test codes. I could rerun the CI to verify this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #527: to fix bug #[10770] by support jboss can config skywalking-agent and start correct
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #527:
URL: https://github.com/apache/skywalking-java/pull/527#issuecomment-1538520002
> Not understand your point of test jboss in the CI.
Do you mean integrate tomcat and test, Could you give me some code or any guide document.
I don't have a JBoss env to test this. Generally, we don't rely on local testing. Most codes should be verified in the CI processes. Such as all plugins in this repository.
So, we need either JBoss to run in the plugin test or e2e test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org