You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2024/02/08 03:23:41 UTC
[I] Experiment: New DRL parser [incubator-kie-drools]
tkobayas opened a new issue, #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678
**Issue Description:**
Migrate a new DRL parser based on antlr 4, because the current DRL parser (based on antlr 3) is hard-coded in the generated Java codes that make it hard to maintain.
**Acceptance Criteria:**
- Migrate a new DRL parser in the drools code base with a feature branch `dev-new-parser`.
- Run unit tests
- Fix and improve the parser by solving the test failures
- It could be several separated issues/PRs which we can work on in parallel
- Improve the parser / implementation design
https://github.com/kiegroup/drools-lsp/pull/48#issue-2120552464
> - Possibly redundant token definitions (`DRL_STRING_LITERAL` in the DRL lexer and `STRING_LITERAL` in the Java lexer).
> - Inconsistent operator tokens (we now have `DRL_MATCHES` but not `DRL_CONTAINS`).
> - What's the benefit of the built-in operator token definitions if we still need to accept pluggable operators?
> - What to do with the overlap between the expression and DRL parsers?
**Out of Scope:**
- Merging this to `main` is out of scope of this issue. When it's ready, we will file a new issue for that
- Once the parser is migrated to `main`, `drools-lsp` will remove its `drools-parser` and refer the new parser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "anand188 (via GitHub)" <gi...@apache.org>.
anand188 commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-2316957292
@tkobayas Hi is there any timeline when we can expect 10.0 with antlr4-runtime updated will be released ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-1933403028
> - Fix and improve the parser by solving the test failures
> - It could be several separated issues/PRs which we can work on in parallel
Each issue would be listed in this issue so that this issue (5678) is the parent issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-1933469791
Test failure : RHS end without preceding white-space
https://github.com/apache/incubator-kie-drools/issues/5679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "seyoatda (via GitHub)" <gi...@apache.org>.
seyoatda commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-2340434111
> @anand188 Sorry, we cannot provide a timeline forecast at the moment.
>
> Btw, I'm interested in why you wait for the antlr4 based parser. Could you let me know? It's implementation details and doesn't directly affect users.
Hi, I'm planning to write a drl formatter/prettier, since there isn't an official one, nor any 3rd-party one. (If there is, plz let me know so that I can just use it.)
I took a look at the `DRL6Lexer.g` & `DRL6Expressions.g` files, and it's a bit annoying to migrate it from antlr3 to anltr4.
Currently I'm handling the migration issues, but if the drools team have done with antlr4 lexer and parser definitions, itโs very helpful XD. ๐
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-1935377834
**Child issue:**
Test failure : Unknown language level
https://github.com/apache/incubator-kie-drools/issues/5681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas closed issue #5678: Experiment: New DRL parser
URL: https://github.com/apache/incubator-kie-drools/issues/5678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-2319660810
@anand188 Sorry, we cannot provide a timeline forecast at the moment.
Btw, I'm interested in why you wait for the antler4 based parser. Could you let me know? It's implementation details and doesn't directly affect users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-1955829673
@yurloc Thank you very much for the effort to raise the issue list! I'm going to start with #5700
- #5700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-2448972920
The new parser has been merged into the main branch (not in `10.0.x` branch). The new parser is not enabled by default at the moment. You can enable it by setting system property `drools.drl.antlr4.parser.enabled` to `true`.
Remaining lower priority issues are aggregated in this Github issue: https://github.com/apache/incubator-kie-drools/issues/5988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-2345590964
Hi @seyoatda ,
It's great to hear that you are willing to develop a drl formatter/prettier. I haven't heard of a drl formatter/prettier. https://github.com/kiegroup/drools-lsp is aiming at a DRL editor, but the development is currently suspended until the new parser will be merged. Also it doesn't include a formatter/prettier feature yet.
> it's a bit annoying to migrate them from antlr3 to anltr4.
The new parser is not yet merged, but you can use the files in my branch.
https://github.com/tkobayas/drools/tree/incubator-kie-drools-5988-merge/drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4
`DRLLexer.g4`, `DRLParser.g4`, `DRL6Expressions.g4` are Apache License, Version 2.0.
`JavaLexer.g4`, `JavaParser.g4` are BSD license. (from `antlr/grammars-v4`)
Cheers,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-1935615961
**Child issue:**
Better implementation switch
https://github.com/apache/incubator-kie-drools/issues/5683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-1933308195
> Migrate a new DRL parser in the drools code base with a feature branch dev-new-parser.
This is done by https://github.com/apache/incubator-kie-drools/pull/5677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "anand188 (via GitHub)" <gi...@apache.org>.
anand188 commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-2317502781
@tkobayas is that fair statement we can expect 10.1 before December, is this something we can wait for ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-2317022083
@anand188 There is no timeline forecast yet. I hope 10.0 (without new parser) release will happen in 1 or 2 months, but not very sure. New parser will be included in the next minor version (probably 10.1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] Experiment: New DRL parser [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5678:
URL: https://github.com/apache/incubator-kie-drools/issues/5678#issuecomment-2159601578
As of 2024-07-11, unit tests are all green. Remaining child issues are low priority, so they can be handled after merging to main.
https://github.com/apache/incubator-kie-drools/issues/5799
https://github.com/apache/incubator-kie-drools/issues/5807
https://github.com/apache/incubator-kie-drools/issues/5856
https://github.com/apache/incubator-kie-drools/issues/5874
https://github.com/apache/incubator-kie-drools/issues/5938
The next step is to create a PR to merge this branch to main branch. Notes:
- Merging has to be done **after** Drools 10.0 release.
- Until the Drools 10.0 release, mark the PR [DO-NOT-MERGE] and make it **draft**.
- Create 2 PRs. One makes the new parser **not** default parser. So it shouldn't affect the default behavior. It is the one to be merged. The other makes the new parser default parser (with a system property switch). It is in order to check any regression error. It's not to be merged, so **draft** PR.
- After Drools 10 release, discuss the future plan in dev@kie.apache ML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org