[GitHub] [tvm] lhutton1 commented on a diff in pull request #13410: [ETHOSN] Add support for experimental compiler option

[GitBox <gi...@apache.org>]

lhutton1 commented on code in PR #13410:
URL: https://github.com/apache/tvm/pull/13410#discussion_r1024184237


##########
python/tvm/relay/op/contrib/ethosn.py:
##########
@@ -101,6 +101,18 @@ def is_inline_non_compute_intensive_partitions_enabled() -> bool:
     return compiler_attrs.inline_non_compute_intensive_partitions
 
 
+def is_experimental_compiler_enabled() -> bool:

Review Comment:
   argh yep this isn't used so should be removed



##########
src/relay/backend/contrib/ethosn/codegen.cc:
##########
@@ -713,9 +713,17 @@ runtime::ethosn::OrderedCompiledNetwork EthosnCompiler::CompileEthosnFunc(const
   auto network_with_ids = ConstructNetwork(mod, gvar, func);
   // Now set the required build flags
   sl::CompilationOptions options = CreateOptions();
-  // Finally compile the network
+  // Set the experimental compiler if enabled, for now this is not part of the

Review Comment:
   my thinking was to reduce the scope of the environment variable to the support library, since its not prefixed in any way there's always the (small!) chance the same variable can be used elsewhere. We could move the scope to the NPU codegen instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org