You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/12/12 21:29:54 UTC
[GitHub] [accumulo] DomGarguilo opened a new pull request, #3121: Replace UtilWaitThread.sleepUninterruptibly with guava equivalent
DomGarguilo opened a new pull request, #3121:
URL: https://github.com/apache/accumulo/pull/3121
`UtilWaitThread.sleepUninterruptibly` was copied from guavas `Uninterruptibles.sleepUninterruptibly` when it was still tagged as beta. With the version of guava we are using, `Uninterruptibles.sleepUninterruptibly` is no longer tagged as beta. This PR removes the copied method and uses guava directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #3121: Replace UtilWaitThread.sleepUninterruptibly with guava equivalent
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #3121:
URL: https://github.com/apache/accumulo/pull/3121#issuecomment-1351591147
> It definitely makes sense to me to first try and use native Java code/utilities when possible, such as lambdas instead of Guavas iterable utilities. But if something doesn't exist I think it would be fine to use the utility in Guava or something like a Commons library so we don't have to re-invent the wheel, assuming the plan isn't to actually remove the dependency entirely at some point.
I agree with these points.
@EdColeman I don't know of/can't find any native java replacements for this. That's not to say one does not exist but I haven't been able to find anything yet.
@dlmarion As for removing guava, I am not sure either. My understanding is that when possible, we should avoid using guava for a built in equivalent, not sure if we have plans to completely remove it as a dependency though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #3121: Replace UtilWaitThread.sleepUninterruptibly with guava equivalent
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #3121:
URL: https://github.com/apache/accumulo/pull/3121#issuecomment-1352029056
I don't think we have a plan to remove Guava entirely. We have tried to avoid the problematic beta methods, certainly. It's also good to reduce our dependency on any external library, Guava is not an exception to that. The `modernizer-maven-plugin` helps identify some of those things. For non-beta methods that we expect to be stable, and for which we expect a minimum Guava version to be required, I don't think it's a problem to use the utility that Guava provides. We'll need to fix the dependency check first before this is merged (just add the guava dependency explicitly to the modules that didn't have it as a compile time dependency before, but now do).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #3121: Replace UtilWaitThread.sleepUninterruptibly with guava equivalent
Posted by GitBox <gi...@apache.org>.
EdColeman commented on PR #3121:
URL: https://github.com/apache/accumulo/pull/3121#issuecomment-1352218137
Is the build failure transient - or is there a dependency that needs to be adjusted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo merged pull request #3121: Replace UtilWaitThread.sleepUninterruptibly with guava equivalent
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged PR #3121:
URL: https://github.com/apache/accumulo/pull/3121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #3121: Replace UtilWaitThread.sleepUninterruptibly with guava equivalent
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #3121:
URL: https://github.com/apache/accumulo/pull/3121#issuecomment-1352231247
> Is the build failure transient - or is there a dependency that needs to be adjusted?
No, it isn't transient. The build is passing from a "used undeclared" dependency warning. Looking into solutions now - should have a fix up soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3121: Replace UtilWaitThread.sleepUninterruptibly with guava equivalent
Posted by GitBox <gi...@apache.org>.
dlmarion commented on PR #3121:
URL: https://github.com/apache/accumulo/pull/3121#issuecomment-1348591195
I thought we were trying to remove Guava dependencies in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #3121: Replace UtilWaitThread.sleepUninterruptibly with guava equivalent
Posted by GitBox <gi...@apache.org>.
EdColeman commented on PR #3121:
URL: https://github.com/apache/accumulo/pull/3121#issuecomment-1347536422
Are there any newer java 11 added options instead of guava?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on pull request #3121: Replace UtilWaitThread.sleepUninterruptibly with guava equivalent
Posted by GitBox <gi...@apache.org>.
cshannon commented on PR #3121:
URL: https://github.com/apache/accumulo/pull/3121#issuecomment-1350984045
It definitely makes sense to me to first try and use native Java code/utilities when possible, such lambdas instead of Guavas iterable utilities, but if something doesn't exist I think it would be fine to use the utility in Guava or something like a Commons library so we don't have to re-invent the wheel, assuming the plan isn't to actually remove the dependency entirely at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #3121: Replace UtilWaitThread.sleepUninterruptibly with guava equivalent
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #3121:
URL: https://github.com/apache/accumulo/pull/3121#issuecomment-1353229681
> Is the build failure transient - or is there a dependency that needs to be adjusted?
Fixed in ac427d0 @EdColeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org