You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/04 21:36:52 UTC
[GitHub] [arrow] hzuo opened a new pull request, #12793: [JS] Improve decode UTF8 performance
hzuo opened a new pull request, #12793:
URL: https://github.com/apache/arrow/pull/12793
While profiling the performance of decoding TPC-H Customer and Part in-browser, datasets where there are a lot of UTF8s, it turned out that much of the time was being spent in `getVariableWidthBytes` - on Chrome it was ~10%, and on Safari it was close to ~40% (Safari's TextDecoder is much faster than Chrome's, so getVariableWidthBytes took up relatively more time).
This is likely because the code in this PR is more amenable to V8/JSC's JIT, since `x` and `y` are guaranteed to be SMIs ("small integers") instead of Object, allowing the JIT to emit efficient machine instructions that only deal in 32-bit integers. Once V8 discovers that a `x` and `y` can potentially be null (upon iterating past the bounds), it "poisons" the codepath forever, since it has to deal with the null case.
See this V8 post for a more in-depth explanation (in particular see the examples underneath "Performance tips"):
https://v8.dev/blog/elements-kinds
Doing the bounds check explicitly instead of implicitly basically eliminates this function from showing up in the profiling. Empirically, on my machine decoding TPC-H Part dropped from 1.9s to 1.7s on Chrome, and Customer dropped from 1.4s to 1.2s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12793: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088037164
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hzuo commented on pull request #12793: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
hzuo commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088039621
Tagging @domoritz for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088130955
Thanks for running these. If you rerun the strings tests only, and run them a few times, do you see a reliable difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hzuo commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
hzuo commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1095974889
I would guess it doesn't matter since it should just be sugar.
To be conservative I prefer the latter syntax since that's the usual style for indexing into typed arrays (so is likely what the engines use in their own benchmarks).
Would benchmark to be sure. Btw, you're probably already aware, but when comparing benchmarks, I had to run a few iterations before the performance stabilized, even across separate invocations to `yarn perf`:
```
for i in {1..5}; do yarn perf; done
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088092039
Thank you. Do you want to try running the benchmarks locally instead of waiting for the bot to get back to us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088044566
Sweet. Thank you for the pull request. Can you open a Jira ticket and add it to the title?
Also, we added memoization to dictionary vectors in the last release. If you have repeating strings, you can save a lot of time by not re-decoding strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1095919509
Ehhh, yes, it does.
With the former we get
```
Running "Iterate Vector" suite...
from: string 13.8 ops/s ±2.3%, 72 ms, 38 samples
Running "Spread Vector" suite...
from: string 14.5 ops/s ±1.7%, 68 ms, 41 samples
Running "toArray Vector" suite...
from: string 14.2 ops/s ±2.0%, 70 ms, 40 samples
Running "get Vector" suite...
from: string 24.2 ops/s ±0.21%, 41 ms, 44 samples
```
and with the latter
```
Running "Iterate Vector" suite...
from: string 23.8 ops/s ±0.23%, 42 ms, 44 samples
Running "Spread Vector" suite...
from: string 19.3 ops/s ±2.9%, 50 ms, 36 samples
Running "toArray Vector" suite...
from: string 19.2 ops/s ±3.6%, 50 ms, 37 samples
Running "get Vector" suite...
from: string 26.2 ops/s ±0.77%, 38 ms, 48 samples
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] trxcllnt commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
trxcllnt commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1090483504
There's other places where we do this same thing. Would probably be good to apply the changes in this PR everywhere IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1095895502
Question, could we replace
```ts
const x = valueOffsets[index];
const y = valueOffsets[index + 1];
```
with
```ts
const { [index]: x, [index + 1]: y } = valueOffsets;
```
or is it necessary not to do that to maintain the performance benefits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hzuo commented on pull request #12793: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
hzuo commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088045809
Sounds good re JIRA ticket.
For these datasets in particular, the UTF8 columns are mostly high cardinality, so I don't think the dictionary would help. But very excited in general!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hzuo commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
hzuo commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088120684
Looks like it's generally faster, but there's also a lot of variance in the two runs across other benchmarks which should not have been impacted, so unclear how much we can attribute to this PR:
https://gist.github.com/hzuo/4a39a661ddd33b740bb7bcb4d85aaa48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hzuo commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
hzuo commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088234971
Benchmarks produced using this diff in case you want to try locally:
https://gist.github.com/hzuo/f06a5a6b5063d4695d73628652e9cb3d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12793: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088045049
Benchmark runs are scheduled for baseline = 7a3bb0dd16809530ac6a2882719a42371cd414ce and contender = 7f1cb70ed6f30154097bd9fb4c074d35ab3857a9. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Only ['Python'] langs are supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e691aa2c4c89444baacf6740a221e62c...38e3265c4fde4851b4d63119a0b0b81d/)
[Skipped :warning: Only ['C++', 'Python', 'R'] langs are supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/428e22ffd674497fabb41df4ea7160a3...7421a00236e24020b9a95339bc792f28/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7cb21e382d3e48879b9dbcaf5c888703...26d9c67d495f467aa43dfc5d5606bd01/)
[Skipped :warning: Only ['C++', 'Java'] langs are supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0c11fe822a1b4eeeae210c730aba96b5...e2075634d15f40e580fc3edfd77cd0ea/)
Buildkite builds:
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/425| `7f1cb70e` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/439| `7a3bb0dd` ec2-t3-xlarge-us-east-2>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/424| `7a3bb0dd` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/424| `7a3bb0dd` ursa-i9-9960x>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/434| `7a3bb0dd` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz closed pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz closed pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
URL: https://github.com/apache/arrow/pull/12793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1090318625
See https://issues.apache.org/jira/browse/ARROW-14801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088051575
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088049791
Arrow is pretty exciting for the browser and I think in the last version we made some pretty sweet API changes. There is definitely still lots of room for perf tricks and convenience methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hzuo commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
hzuo commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1089818498
Of course, happy to help! Let me know if there's anything else before getting this merged.
@domoritz what does the release schedule look like? Will the next release be aligned with an Arrow major version bump or are you amenable to releasing a minor version as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088156641
Comment out the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12793: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088043093
Supported benchmark command examples:
`@ursabot benchmark help`
To run all benchmarks:
`@ursabot please benchmark`
To filter benchmarks by language:
`@ursabot please benchmark lang=Python`
`@ursabot please benchmark lang=C++`
`@ursabot please benchmark lang=R`
`@ursabot please benchmark lang=Java`
`@ursabot please benchmark lang=JavaScript`
To filter Python and R benchmarks by name:
`@ursabot please benchmark name=file-write`
`@ursabot please benchmark name=file-write lang=Python`
`@ursabot please benchmark name=file-.*`
To filter C++ benchmarks by archery --suite-filter and --benchmark-filter:
`@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3`
For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088051541
https://issues.apache.org/jira/browse/ARROW-16117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1091137120
Benchmark runs are scheduled for baseline = 88eea9cf6b0a9bcfffa8d75b2e2e1f98a81d4c73 and contender = adfa60504b7521c26bb0c53732b12a7e1aa180c7. adfa60504b7521c26bb0c53732b12a7e1aa180c7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f8870ed04ea547a29451a374276821c0...caf005755fce4469a1c98a55a6bbb939/)
[Finished :arrow_down:0.08% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f05d7f4e74474498a6843539eec52b99...4452bf4eb39f49bc8059bb5d19748953/)
[Failed :arrow_down:0.72% :arrow_up:1.43%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f3b3d5c5bb0f4a0ab28d1903ec5e4c1a...957fbfefb0f744d2a9845da16e807a3d/)
[Finished :arrow_down:0.17% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/641750d6d7d5424ca069d6f1b6447721...eac15788af63459f8a7661a6711cca42/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/457| `adfa6050` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/442| `adfa6050` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/443| `adfa6050` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/452| `adfa6050` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/456| `88eea9cf` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/441| `88eea9cf` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/442| `88eea9cf` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/451| `88eea9cf` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088637275
Thank you so much for the pull request and digging into the benchmarks to confirm it's better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088043079
@ursabot bench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hzuo commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
hzuo commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088232577
Ok sweet, yeah scoping to only string tests, the performance is actually pretty stable across 5 runs. Looks this PR is consistently 30% faster than master!
### On master
```
❯ git branch -v
hz/dp 7f1cb70ed speed up getVariableWidthBytes
* master 7a3bb0dd1 ARROW-16110: [C++] GcsFileSystem::Make ignores IOContext
arrow/js on 🌱 master [!] is 📦 v8.0.0-SNAPSHOT via 🤖 v16.14.2
❯ for i in {1..5}; do yarn perf; done
yarn run v1.22.18
$ node --loader ts-node/esm/transpile-only ./perf/index.ts
(node:35293) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Prepare Data: 891.8ms
Running "Iterate Vector" suite...
from: string 2.78 ops/s ±3.7%, 364 ms, 11 samples
Running "Spread Vector" suite...
from: string 2.58 ops/s ±2.5%, 390 ms, 11 samples
Running "toArray Vector" suite...
from: string 2.63 ops/s ±1.7%, 382 ms, 11 samples
Running "get Vector" suite...
from: string 3.52 ops/s ±5.7%, 282 ms, 13 samples
✨ Done in 37.73s.
yarn run v1.22.18
$ node --loader ts-node/esm/transpile-only ./perf/index.ts
(node:35304) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Prepare Data: 898.588ms
Running "Iterate Vector" suite...
from: string 2.73 ops/s ±4.1%, 371 ms, 11 samples
Running "Spread Vector" suite...
from: string 2.49 ops/s ±3.1%, 404 ms, 11 samples
Running "toArray Vector" suite...
from: string 2.58 ops/s ±2.3%, 392 ms, 11 samples
Running "get Vector" suite...
from: string 3.49 ops/s ±6.0%, 276 ms, 13 samples
✨ Done in 38.39s.
yarn run v1.22.18
$ node --loader ts-node/esm/transpile-only ./perf/index.ts
(node:35308) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Prepare Data: 900.138ms
Running "Iterate Vector" suite...
from: string 2.79 ops/s ±3.7%, 365 ms, 11 samples
Running "Spread Vector" suite...
from: string 2.58 ops/s ±3.3%, 384 ms, 11 samples
Running "toArray Vector" suite...
from: string 2.62 ops/s ±1.6%, 382 ms, 11 samples
Running "get Vector" suite...
from: string 3.55 ops/s ±6.2%, 271 ms, 13 samples
✨ Done in 37.60s.
yarn run v1.22.18
$ node --loader ts-node/esm/transpile-only ./perf/index.ts
(node:35313) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Prepare Data: 890.689ms
Running "Iterate Vector" suite...
from: string 2.76 ops/s ±3.5%, 369 ms, 11 samples
Running "Spread Vector" suite...
from: string 2.48 ops/s ±2.3%, 403 ms, 11 samples
Running "toArray Vector" suite...
from: string 2.56 ops/s ±2.6%, 394 ms, 11 samples
Running "get Vector" suite...
from: string 3.51 ops/s ±6.0%, 277 ms, 13 samples
✨ Done in 38.24s.
yarn run v1.22.18
$ node --loader ts-node/esm/transpile-only ./perf/index.ts
(node:35316) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Prepare Data: 905.984ms
Running "Iterate Vector" suite...
from: string 2.81 ops/s ±3.8%, 360 ms, 11 samples
Running "Spread Vector" suite...
from: string 2.52 ops/s ±2.4%, 399 ms, 11 samples
Running "toArray Vector" suite...
from: string 2.54 ops/s ±2.7%, 395 ms, 11 samples
Running "get Vector" suite...
from: string 3.5 ops/s ±6.2%, 274 ms, 13 samples
✨ Done in 38.20s.
```
---
## This PR
```
❯ git branch -v
* hz/dp 7f1cb70ed speed up getVariableWidthBytes
master 7a3bb0dd1 ARROW-16110: [C++] GcsFileSystem::Make ignores IOContext
arrow/js on 🌱 hz/dp [!] is 📦 v8.0.0-SNAPSHOT via 🤖 v16.14.2
❯ for i in {1..5}; do yarn perf; done
yarn run v1.22.18
$ node --loader ts-node/esm/transpile-only ./perf/index.ts
(node:34959) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Prepare Data: 896.896ms
Running "Iterate Vector" suite...
from: string 3.61 ops/s ±6.4%, 267 ms, 13 samples
Running "Spread Vector" suite...
from: string 3.47 ops/s ±6.3%, 289 ms, 13 samples
Running "toArray Vector" suite...
from: string 3.36 ops/s ±5.9%, 290 ms, 13 samples
Running "get Vector" suite...
from: string 3.44 ops/s ±4.6%, 279 ms, 13 samples
✨ Done in 35.45s.
yarn run v1.22.18
$ node --loader ts-node/esm/transpile-only ./perf/index.ts
(node:34964) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Prepare Data: 901.415ms
Running "Iterate Vector" suite...
from: string 3.65 ops/s ±5.5%, 269 ms, 14 samples
Running "Spread Vector" suite...
from: string 3.42 ops/s ±6.7%, 299 ms, 13 samples
Running "toArray Vector" suite...
from: string 3.53 ops/s ±6.0%, 282 ms, 13 samples
Running "get Vector" suite...
from: string 3.52 ops/s ±3.4%, 280 ms, 13 samples
✨ Done in 35.54s.
yarn run v1.22.18
$ node --loader ts-node/esm/transpile-only ./perf/index.ts
(node:34967) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Prepare Data: 898.33ms
Running "Iterate Vector" suite...
from: string 3.66 ops/s ±5.8%, 265 ms, 14 samples
Running "Spread Vector" suite...
from: string 3.42 ops/s ±5.8%, 294 ms, 13 samples
Running "toArray Vector" suite...
from: string 3.56 ops/s ±7.1%, 272 ms, 13 samples
Running "get Vector" suite...
from: string 3.53 ops/s ±3.6%, 280 ms, 13 samples
✨ Done in 35.54s.
yarn run v1.22.18
$ node --loader ts-node/esm/transpile-only ./perf/index.ts
(node:34970) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Prepare Data: 901.96ms
Running "Iterate Vector" suite...
from: string 3.61 ops/s ±6.1%, 273 ms, 13 samples
Running "Spread Vector" suite...
from: string 3.43 ops/s ±5.9%, 298 ms, 13 samples
Running "toArray Vector" suite...
from: string 3.43 ops/s ±7.1%, 280 ms, 13 samples
Running "get Vector" suite...
from: string 3.47 ops/s ±4.6%, 277 ms, 13 samples
✨ Done in 35.36s.
yarn run v1.22.18
$ node --loader ts-node/esm/transpile-only ./perf/index.ts
(node:34973) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Prepare Data: 884.961ms
Running "Iterate Vector" suite...
from: string 3.66 ops/s ±5.7%, 265 ms, 14 samples
Running "Spread Vector" suite...
from: string 3.45 ops/s ±6.6%, 306 ms, 13 samples
Running "toArray Vector" suite...
from: string 3.49 ops/s ±5.5%, 285 ms, 13 samples
Running "get Vector" suite...
from: string 3.54 ops/s ±4.5%, 271 ms, 13 samples
✨ Done in 35.33s.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088051561
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1090167768
This will be in the next major release. Doing independent releases is possible but we need to set up scripts to upload release artifacts so we follow Apache rules. I'd rather set up nightlies but haven't had cycles. I discussed this on the mailing list. It will only happen if someone steps up to set things up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hzuo commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
hzuo commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088143807
Is there a way via npm scripts or should I comment out cases in the benchmarking code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088044813
@ursabot please benchmark lang=JavaScript
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #12793: ARROW-16117: [JS] Improve decode UTF8 performance
Posted by GitBox <gi...@apache.org>.
domoritz commented on PR #12793:
URL: https://github.com/apache/arrow/pull/12793#issuecomment-1088635117
The ci agrees. 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org