You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "tanishqgandhi1908 (via GitHub)" <gi...@apache.org> on 2026/10/22 01:00:30 UTC
[PR] fix(frontend): clear the search bar’s suggestions when the user changes [texera]
tanishqgandhi1908 opened a new pull request, #9090:
URL: https://github.com/apache/texera/pull/9090
### What changes were proposed in this PR?
The top search bar caches its suggestions by the typed text and never cleared that cache. After signing out you land on the About page with the same search bar, and typing text searched before sign-out showed the previous user’s suggestions again, including private workflows, datasets and models, straight from the cache.
SearchBarComponent now clears the cache and the shown suggestions in its existing userChanged() handler, which runs on sign-in and sign-out.
Before: signed out, “sales” still suggests the private dataset sales-2026, and no request is sent:
<img width="1440" height="900" alt="before-2-logged-out-still-suggested" src="https://github.com/user-attachments/assets/818ad412-162e-4f3d-bfbc-978647753167" />
After: signed out, “sales” goes to the public search and suggests nothing:
<img width="1440" height="900" alt="after-1-logged-out-no-suggestion" src="https://github.com/user-attachments/assets/10335c5f-c4a9-4241-9e42-8b383658d9a8" />
### Any related issues, documentation, discussions?
Closes #9089
### How was this PR tested?
Added a case to search-bar.component.spec.ts: after the user changes, a repeated query goes to the server as the new user instead of returning the cached suggestions. It fails without the fix.
```
cd frontend
yarn ng test --watch=false --include='**/search-bar.component.spec.ts'
# Tests 10 passed (10)
```
Also checked against a local stack: signed in, typed a private dataset’s name, signed out, and typed it again. No suggestion is shown, and a public search request is sent.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): clear the search bar’s suggestions when the user changes [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9090:
URL: https://github.com/apache/texera/pull/9090#issuecomment-6334227670
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/9090?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.30%. Comparing base ([`3ba45ee`](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3d3dd8e`](https://app.codecov.io/gh/apache/texera/commit/3d3dd8e955580b470e22ab8f83dfc6eaa12586c6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (3ba45ee) and HEAD (3d3dd8e). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (3ba45ee) | HEAD (3d3dd8e) |
>|------|------|------|
>|frontend|2|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #9090 +/- ##
=============================================
- Coverage 92.33% 73.30% -19.04%
Complexity 5045 5045
=============================================
Files 1261 1160 -101
Lines 54120 47526 -6594
Branches 6768 5672 -1096
=============================================
- Hits 49973 34837 -15136
- Misses 2486 10856 +8370
- Partials 1661 1833 +172
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.31% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.48% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.00% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.31% <100.00%> (-49.25%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.57% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/9090/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.43% <ø> (ø)` | | Carriedforward from [3ba45ee](https://app.codecov.io/gh/apache/texera/commit/3ba45ee5a5f641388d1a9eda90afa26a62d70d30?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/9090?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): clear the search bar’s suggestions when the user changes [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9090:
URL: https://github.com/apache/texera/pull/9090#issuecomment-6330649778
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`
You can notify them by mentioning `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): clear the search bar’s suggestions when the user changes [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9090:
URL: https://github.com/apache/texera/pull/9090#issuecomment-6330632396
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. A `release/*` label nominates a backport target; the branch's release manager approving this PR is what sends the fix there. The required **Backport Approvals** check stays red until every label below is approved, so each manager either approves or removes their own label — which is why the labels left on a merged PR are exactly the branches it reached.
| Release branch | Analysis |
| --- | --- |
| ✅ `release/v1.3` | Change detected on this branch — label added; this fix is queued to backport here. @mengw15 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested. |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. @xuang7 decides: approving sends the fix here, removing this label declines it. The merge waits on one or the other. Review requested. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/39703125031)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org