[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #32344:
URL: https://github.com/apache/spark/pull/32344#discussion_r620351073



##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerKrbJDBCIntegrationSuite.scala
##########
@@ -160,4 +161,53 @@ abstract class DockerKrbJDBCIntegrationSuite extends DockerJDBCIntegrationSuite
     assert(rows(0).getString(0) === "foo")
     assert(rows(0).getString(1) === "bar")
   }
+
+  test("SPARK-35226: JDBCOption should accept refreshKrb5Config parameter") {
+    // This makes sure Spark must do authentication
+    Configuration.setConfiguration(null)
+    withTempDir { dir =>
+      val dummyKrb5Conf = File.createTempFile("dummy", "krb5.conf", dir)
+      val origKrb5Conf = sys.props("java.security.krb5.conf")

Review comment:
       Shall we use the pre-defined `KRB5_CONF_PROP` instead of `java.security.krb5.conf`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org