You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by GitBox <gi...@apache.org> on 2021/12/24 12:45:21 UTC
[GitHub] [jclouds] SATYANAN-ANAND opened a new pull request #128: Update ClientCredentialsClaims.java
SATYANAN-ANAND opened a new pull request #128:
URL: https://github.com/apache/jclouds/pull/128
JCLOUDS-1591: OAuth: ClientCredentialsJWTBearerTokenFlow.filter method throws Null Pointer Exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jclouds] gaul commented on pull request #128: Update ClientCredentialsClaims.java
Posted by GitBox <gi...@apache.org>.
gaul commented on pull request #128:
URL: https://github.com/apache/jclouds/pull/128#issuecomment-1001393292
Thank you for your contribution @SATYANAN-ANAND!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jclouds] gaul merged pull request #128: Update ClientCredentialsClaims.java
Posted by GitBox <gi...@apache.org>.
gaul merged pull request #128:
URL: https://github.com/apache/jclouds/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jclouds] gaul commented on a change in pull request #128: Update ClientCredentialsClaims.java
Posted by GitBox <gi...@apache.org>.
gaul commented on a change in pull request #128:
URL: https://github.com/apache/jclouds/pull/128#discussion_r775010584
##########
File path: apis/oauth/src/main/java/org/jclouds/oauth/v2/domain/ClientCredentialsClaims.java
##########
@@ -49,6 +50,7 @@
public abstract long nbf();
/** "JWT ID", a unique identifier for the JWT. */
+ @Nullable
Review comment:
Should this also annotate the `create` method with `@Nullable` as the [AutoValue documentation suggests](https://github.com/google/auto/blob/master/value/userguide/howto.md#nullable)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #128: Update ClientCredentialsClaims.java
Posted by GitBox <gi...@apache.org>.
SATYANAN-ANAND commented on a change in pull request #128:
URL: https://github.com/apache/jclouds/pull/128#discussion_r775366148
##########
File path: apis/oauth/src/main/java/org/jclouds/oauth/v2/domain/ClientCredentialsClaims.java
##########
@@ -49,6 +50,7 @@
public abstract long nbf();
/** "JWT ID", a unique identifier for the JWT. */
+ @Nullable
Review comment:
Modified as per the comment and commit the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org