You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "boushphong (via GitHub)" <gi...@apache.org> on 2023/11/03 22:59:31 UTC
[PR] Fix TriggerDagRunOperator failing to trigger subsequent runs when reset_dag_run=True [airflow]
boushphong opened a new pull request, #35429:
URL: https://github.com/apache/airflow/pull/35429
closes: #34953
**In brief:**
The operator failed to reset the dag run because it failed to handle a case where:
```python
parsed_execution_date = timezone.utcnow()
```
This causes the code in:
```python
dag.clear(start_date=parsed_execution_date, end_date=parsed_execution_date)
```
to fail because `parsed_execution_date` will be used as arguments for a where clause to filter out task instances to be cleared. This would cause a bug since no task instances would be able to returned from the call when we set the filter to `parsed_execution_date = timezone.utcnow()`.
Modification:
Use `dagrun.execution_date` to guarantee that task instances can be correctly filtered and cleared when resetting the DAG run.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix TriggerDagRunOperator failing to trigger subsequent runs when reset_dag_run=True [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35429:
URL: https://github.com/apache/airflow/pull/35429#issuecomment-1793479891
Nice one! Thanks for being responsive :) !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix TriggerDagRunOperator failing to trigger subsequent runs when reset_dag_run=True [airflow]
Posted by "boushphong (via GitHub)" <gi...@apache.org>.
boushphong commented on PR #35429:
URL: https://github.com/apache/airflow/pull/35429#issuecomment-1793374639
I added the test.
PTAL at your convenience :bow:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix TriggerDagRunOperator failing to trigger subsequent runs when reset_dag_run=True [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35429:
URL: https://github.com/apache/airflow/pull/35429#issuecomment-1793250953
Sounds legit, but I think we need a test case covering it to avoid regressions in the future. Especially for such "core" operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix TriggerDagRunOperator failing to trigger subsequent runs when reset_dag_run=True [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #35429:
URL: https://github.com/apache/airflow/pull/35429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org