You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by souravmitra <gi...@git.apache.org> on 2017/04/06 11:59:26 UTC
[GitHub] storm pull request #2046: STORM-2458: Kafka Spout should allow hooking up cu...
GitHub user souravmitra opened a pull request:
https://github.com/apache/storm/pull/2046
STORM-2458: Kafka Spout should allow hooking up custom logic when ret\u2026
Kafka Spout should allow hooking up custom logic when retries have exhausted
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/souravmitra/storm AddedCustomLogicAfterRetriesFinish
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2046.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2046
----
commit 8c5dba2065cc0fbefbbf022ecf178339c4021ce9
Author: Sourav Mitra <so...@gmail.com>
Date: 2017-04-06T11:53:35Z
STORM-2458: Kafka Spout should allow hooking up custom logic when retries have exhanusted
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2046: STORM-2458: Kafka Spout should allow hooking up custom lo...
Posted by souravmitra <gi...@git.apache.org>.
Github user souravmitra commented on the issue:
https://github.com/apache/storm/pull/2046
Hello @HeartSavior @vesense Would you mind having a look, it's a very small change. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2046: STORM-2458: Kafka Spout should allow hooking up cu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2046
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2046: STORM-2458: Kafka Spout should allow hooking up custom lo...
Posted by souravmitra <gi...@git.apache.org>.
Github user souravmitra commented on the issue:
https://github.com/apache/storm/pull/2046
@vesense : Would you mind merging this in master please, would be very helpful. Appreciate your quick feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2046: STORM-2458: Kafka Spout should allow hooking up custom lo...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2046
@souravmitra Yes, I will merge it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2046: STORM-2458: Kafka Spout should allow hooking up custom lo...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2046
Looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---