You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/03/16 13:00:28 UTC

Review Request 57688: Start/Stop Service command may silently fail without any reporting for user

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57688/
-----------------------------------------------------------

Review request for Ambari and Denys Buzhor.


Bugs: ambari-20481
    https://issues.apache.org/jira/browse/ambari-20481


Repository: ambari


Description
-------

* Go to HDFS
* Click "Start" or "Stop" on Service Actions menu
* Request may fails

*ER* Popup with reason should be shown (e.g. {{defaultErrorHandler}})
*AR* Nothing happens


Diffs
-----

  ambari-web/app/controllers/main/service/item.js 5169564 
  ambari-web/test/controllers/main/service/item_test.js c4a50ea 


Diff: https://reviews.apache.org/r/57688/diff/1/


Testing
-------

20580 passing (22s)
  153 pending


Thanks,

Oleg Nechiporenko


Re: Review Request 57688: Start/Stop Service command may silently fail without any reporting for user

Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57688/#review169153
-----------------------------------------------------------


Ship it!




Ship It!

- Denys Buzhor


On March 16, 2017, 1 p.m., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57688/
> -----------------------------------------------------------
> 
> (Updated March 16, 2017, 1 p.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20481
>     https://issues.apache.org/jira/browse/ambari-20481
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Go to HDFS
> * Click "Start" or "Stop" on Service Actions menu
> * Request may fails
> 
> *ER* Popup with reason should be shown (e.g. {{defaultErrorHandler}})
> *AR* Nothing happens
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/item.js 5169564 
>   ambari-web/test/controllers/main/service/item_test.js c4a50ea 
> 
> 
> Diff: https://reviews.apache.org/r/57688/diff/1/
> 
> 
> Testing
> -------
> 
> 20580 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>