You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/16 09:25:23 UTC
[GitHub] [arrow-rs] Dandandan opened a new pull request, #3353: Deprecate flight_data_from_arrow_batch
Dandandan opened a new pull request, #3353:
URL: https://github.com/apache/arrow-rs/pull/3353
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3312
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
It encourages inefficient usage of the flight api (as dictionaries are returned over and over). It is relatively easy to use the same API used in this method at the implementation side.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3353: Deprecate flight_data_from_arrow_batch
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3353:
URL: https://github.com/apache/arrow-rs/pull/3353#issuecomment-1354863538
Benchmark runs are scheduled for baseline = 309cf5cd299dbf91235b60876e092c1af3990b84 and contender = 3039633d57b78d20fc4d9ae9165c0d0777e81bb7. 3039633d57b78d20fc4d9ae9165c0d0777e81bb7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ed238cdb76f64311aa950e46c4d52568...7030708bdf38416da04f6cbee4626348/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/6a9fc511b67a442fac6a36012dfb9d0b...eb1195166cb446a28e3ccc819305a04d/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9f0f5877ef72445284972b3e3fd9d366...4c87e85164fd4045b8d65e9ebc03608e/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fa3567e9e7874a0691fb4557dd12884d...9283c63d9c4b42ca9d8a9dd1d469938a/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3353: Deprecate flight_data_from_arrow_batch
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3353:
URL: https://github.com/apache/arrow-rs/pull/3353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan commented on a diff in pull request #3353: Deprecate flight_data_from_arrow_batch
Posted by GitBox <gi...@apache.org>.
Dandandan commented on code in PR #3353:
URL: https://github.com/apache/arrow-rs/pull/3353#discussion_r1050549260
##########
arrow-flight/src/utils.rs:
##########
@@ -149,11 +153,16 @@ pub fn batches_to_flight_data(
let schema_flight_data: FlightData = SchemaAsIpc::new(&schema, &options).into();
let mut dictionaries = vec![];
let mut flight_data = vec![];
+
+ let data_gen = writer::IpcDataGenerator::default();
Review Comment:
So this is the basic difference in API (quite limited).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3353: Deprecate flight_data_from_arrow_batch
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3353:
URL: https://github.com/apache/arrow-rs/pull/3353#issuecomment-1354562831
Also related - https://github.com/apache/arrow-rs/pull/3354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org