You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sneha Kanekar <sk...@us.ibm.com> on 2017/12/21 15:21:10 UTC
Review Request 64775: Store and retrieve the ambari repo urls for os
family during bootstrap
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-22394
https://issues.apache.org/jira/browse/AMBARI-22394
Repository: ambari
Description
-------
Ambari configuration will have list of repo urls for each os type. During bootstrap, the stored repo url will be used to correct the base url from ambari.repo file on agent host.
Diffs
-----
ambari-server/src/main/python/bootstrap.py f1c53ce
ambari-server/src/main/python/os_check_type.py da37560
ambari-server/src/main/python/setupAgent.py efc3d7c
ambari-server/src/test/python/TestBootstrap.py bea47f4
ambari-server/src/test/python/TestSetupAgent.py 0b33e9f
Diff: https://reviews.apache.org/r/64775/diff/1/
Testing
-------
Tests were successful in ambari-server.
Thanks,
Sneha Kanekar
Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari
repo urls for os family during bootstrap
Posted by Sneha Kanekar <sk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/
-----------------------------------------------------------
(Updated Jan. 3, 2018, 3:47 a.m.)
Review request for Ambari and Nate Cole.
Bugs: AMBARI-22394
https://issues.apache.org/jira/browse/AMBARI-22394
Repository: ambari
Description
-------
Ambari configuration will have list of repo urls for each os type. During bootstrap, the stored repo url will be used to correct the base url from ambari repo file on agent host.
Diffs
-----
ambari-server/src/main/python/bootstrap.py f1c53ce
ambari-server/src/main/python/os_check_type.py da37560
ambari-server/src/main/python/setupAgent.py efc3d7c
ambari-server/src/test/python/TestBootstrap.py bea47f4
ambari-server/src/test/python/TestSetupAgent.py 0b33e9f
Diff: https://reviews.apache.org/r/64775/diff/2/
Testing
-------
Tests were successful in ambari-server.
Thanks,
Sneha Kanekar
Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari
repo urls for os family during bootstrap
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/#review194636
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Dec. 23, 2017, 2:16 a.m., Sneha Kanekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64775/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2017, 2:16 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22394
> https://issues.apache.org/jira/browse/AMBARI-22394
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari configuration will have list of repo urls for each os type. During bootstrap, the stored repo url will be used to correct the base url from ambari repo file on agent host.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/bootstrap.py f1c53ce
> ambari-server/src/main/python/os_check_type.py da37560
> ambari-server/src/main/python/setupAgent.py efc3d7c
> ambari-server/src/test/python/TestBootstrap.py bea47f4
> ambari-server/src/test/python/TestSetupAgent.py 0b33e9f
>
>
> Diff: https://reviews.apache.org/r/64775/diff/2/
>
>
> Testing
> -------
>
> Tests were successful in ambari-server.
>
>
> Thanks,
>
> Sneha Kanekar
>
>
Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari
repo urls for os family during bootstrap
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/#review194638
-----------------------------------------------------------
This has been pushed. Please close this review and associated JIRA.
- Nate Cole
On Dec. 23, 2017, 2:16 a.m., Sneha Kanekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64775/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2017, 2:16 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22394
> https://issues.apache.org/jira/browse/AMBARI-22394
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari configuration will have list of repo urls for each os type. During bootstrap, the stored repo url will be used to correct the base url from ambari repo file on agent host.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/bootstrap.py f1c53ce
> ambari-server/src/main/python/os_check_type.py da37560
> ambari-server/src/main/python/setupAgent.py efc3d7c
> ambari-server/src/test/python/TestBootstrap.py bea47f4
> ambari-server/src/test/python/TestSetupAgent.py 0b33e9f
>
>
> Diff: https://reviews.apache.org/r/64775/diff/2/
>
>
> Testing
> -------
>
> Tests were successful in ambari-server.
>
>
> Thanks,
>
> Sneha Kanekar
>
>
Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari
repo urls for os family during bootstrap
Posted by Sneha Kanekar <sk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/
-----------------------------------------------------------
(Updated Dec. 23, 2017, 7:16 a.m.)
Review request for Ambari and Nate Cole.
Changes
-------
Made syntax changes and added required information for the user.
Bugs: AMBARI-22394
https://issues.apache.org/jira/browse/AMBARI-22394
Repository: ambari
Description
-------
Ambari configuration will have list of repo urls for each os type. During bootstrap, the stored repo url will be used to correct the base url from ambari repo file on agent host.
Diffs (updated)
-----
ambari-server/src/main/python/bootstrap.py f1c53ce
ambari-server/src/main/python/os_check_type.py da37560
ambari-server/src/main/python/setupAgent.py efc3d7c
ambari-server/src/test/python/TestBootstrap.py bea47f4
ambari-server/src/test/python/TestSetupAgent.py 0b33e9f
Diff: https://reviews.apache.org/r/64775/diff/2/
Changes: https://reviews.apache.org/r/64775/diff/1-2/
Testing
-------
Tests were successful in ambari-server.
Thanks,
Sneha Kanekar
Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari
repo urls for os family during bootstrap
Posted by Nate Cole <nc...@hortonworks.com>.
> On Dec. 22, 2017, 10:12 a.m., Nate Cole wrote:
> > ambari-server/src/main/python/bootstrap.py
> > Lines 762-763 (patched)
> > <https://reviews.apache.org/r/64775/diff/1/?file=1926153#file1926153line762>
> >
> > Use "".format() syntax here.
> >
> > Should we give more information here? How will we tell the user what to do? How do they get the os_type into ambari.properties?
Please mark these as Fixed when they are updated in a diff.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/#review194436
-----------------------------------------------------------
On Dec. 23, 2017, 2:16 a.m., Sneha Kanekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64775/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2017, 2:16 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22394
> https://issues.apache.org/jira/browse/AMBARI-22394
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari configuration will have list of repo urls for each os type. During bootstrap, the stored repo url will be used to correct the base url from ambari repo file on agent host.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/bootstrap.py f1c53ce
> ambari-server/src/main/python/os_check_type.py da37560
> ambari-server/src/main/python/setupAgent.py efc3d7c
> ambari-server/src/test/python/TestBootstrap.py bea47f4
> ambari-server/src/test/python/TestSetupAgent.py 0b33e9f
>
>
> Diff: https://reviews.apache.org/r/64775/diff/2/
>
>
> Testing
> -------
>
> Tests were successful in ambari-server.
>
>
> Thanks,
>
> Sneha Kanekar
>
>
Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari
repo urls for os family during bootstrap
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/#review194436
-----------------------------------------------------------
ambari-server/src/main/python/bootstrap.py
Lines 762-763 (patched)
<https://reviews.apache.org/r/64775/#comment273203>
Use "".format() syntax here.
Should we give more information here? How will we tell the user what to do? How do they get the os_type into ambari.properties?
- Nate Cole
On Dec. 21, 2017, 10:25 a.m., Sneha Kanekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64775/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2017, 10:25 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22394
> https://issues.apache.org/jira/browse/AMBARI-22394
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari configuration will have list of repo urls for each os type. During bootstrap, the stored repo url will be used to correct the base url from ambari repo file on agent host.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/bootstrap.py f1c53ce
> ambari-server/src/main/python/os_check_type.py da37560
> ambari-server/src/main/python/setupAgent.py efc3d7c
> ambari-server/src/test/python/TestBootstrap.py bea47f4
> ambari-server/src/test/python/TestSetupAgent.py 0b33e9f
>
>
> Diff: https://reviews.apache.org/r/64775/diff/1/
>
>
> Testing
> -------
>
> Tests were successful in ambari-server.
>
>
> Thanks,
>
> Sneha Kanekar
>
>
Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari
repo urls for os family during bootstrap
Posted by Sneha Kanekar <sk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/
-----------------------------------------------------------
(Updated Dec. 21, 2017, 3:25 p.m.)
Review request for Ambari and Nate Cole.
Summary (updated)
-----------------
AMBARI-22394: Store and retrieve the ambari repo urls for os family during bootstrap
Bugs: AMBARI-22394
https://issues.apache.org/jira/browse/AMBARI-22394
Repository: ambari
Description (updated)
-------
Ambari configuration will have list of repo urls for each os type. During bootstrap, the stored repo url will be used to correct the base url from ambari repo file on agent host.
Diffs
-----
ambari-server/src/main/python/bootstrap.py f1c53ce
ambari-server/src/main/python/os_check_type.py da37560
ambari-server/src/main/python/setupAgent.py efc3d7c
ambari-server/src/test/python/TestBootstrap.py bea47f4
ambari-server/src/test/python/TestSetupAgent.py 0b33e9f
Diff: https://reviews.apache.org/r/64775/diff/1/
Testing
-------
Tests were successful in ambari-server.
Thanks,
Sneha Kanekar