You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/01 01:55:13 UTC

[GitHub] [apisix] tokers commented on a change in pull request #4347: perf: use events optimize nacos service discovery

tokers commented on a change in pull request #4347:
URL: https://github.com/apache/apisix/pull/4347#discussion_r642733798



##########
File path: apisix/discovery/nacos.lua
##########
@@ -311,7 +322,17 @@ local function fetch_full_registry(premature)
             })
         end
     end
+    local new_apps_md5sum = ngx.md5(core.json.encode(up_apps))
+    local old_apps_md5sum = ngx.md5(core.json.encode(applications));

Review comment:
       ```suggestion
       local old_apps_md5sum = ngx.md5(core.json.encode(applications))
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org