[GitHub] [hbase] ndimiduk commented on a change in pull request #1310: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #1310: HBASE-23957 [flakey test] client.TestMultiParallel fails to read hbas…
URL: https://github.com/apache/hbase/pull/1310#discussion_r395215560
 
 

 ##########
 File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncClusterAdminApi.java
 ##########
 @@ -65,19 +67,51 @@
   public static final HBaseClassTestRule CLASS_RULE =
       HBaseClassTestRule.forClass(TestAsyncClusterAdminApi.class);
 
-  private final Path cnfPath = FileSystems.getDefault().getPath("target/test-classes/hbase-site.xml");
-  private final Path cnf2Path = FileSystems.getDefault().getPath("target/test-classes/hbase-site2.xml");
-  private final Path cnf3Path = FileSystems.getDefault().getPath("target/test-classes/hbase-site3.xml");
+  private static List<Path> newCnfPathes = new ArrayList<>();
 
   @BeforeClass
   public static void setUpBeforeClass() throws Exception {
+    // Before this change, the test will update hbase-site.xml under target/test-classes and
+    // trigger a config reload. Since target/test-classes/hbase-site.xml is being used by
+    // other testing cases at the same time, this update will break other testing cases so it will
+    // be flakey in nature.
+    // To avoid this, the change is to make target/test-classes/hbase-site.xml immutable. A new
+    // hbase-site.xml will be created under its test data directory, i.e,
+    // hbase-server/target/test-data/UUID, this new file will be added as a resource for the
+    // config, new update will be applied to this new file and only visible to this specific test
+    // case. The target/test-classes/hbase-site.xml will not be changed during the test.
+    String absoluteDataPath = TEST_UTIL.getDataTestDir().toString();
+    String dataBasePath = TEST_UTIL.getBaseTestDir().toString();
+    String dataPath = absoluteDataPath.substring(absoluteDataPath.indexOf(dataBasePath));
 
 Review comment:
   Yikes! Can you use the `File` or `Path` APIs instead of doing string manipulation?
   
   Why is a relative path necessary anyway?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services