You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/22 09:18:37 UTC

[GitHub] [beam] timrobertson100 commented on pull request #14933: [BEAM-12421] Migrates ElasticsearchIOTest to use testContainers

timrobertson100 commented on pull request #14933:
URL: https://github.com/apache/beam/pull/14933#issuecomment-865799403


   Thanks, @TheNeuralBit, @egalpin 
   
   I looked over the code and was happy with it with only the one high-level comment which is resolved (we'll remove duplication in a different issue). I am afraid I am not familiar enough with decisions in the Beam project around use of containers to know if this is a welcome addition to merge, or the consequences. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org