Re: [PR] feat(firebird): add FirebirdStatement to bypass sqlglot parsing [superset]

["betodealmeida (via GitHub)" <gi...@apache.org>]

betodealmeida commented on code in PR #39389:
URL: https://github.com/apache/superset/pull/39389#discussion_r3436944451


##########
superset/sql/parse.py:
##########
@@ -1277,6 +1508,7 @@ class SQLScript:
     # adds a lot of complexity to Superset, so we should avoid adding new engines to
     # this data structure.
     special_engines = {
+        "firebird": FirebirdStatement,

Review Comment:
   We really don't want to extend this list because using regex to parse SQL will open so many CVEs. The only reason why Kusto is here is because it was grandfathered when we migrated from `sqlparse` to `sqlglot`.
   
   It shouldn't be hard to write a Firebird dialect, like we've done for DB2, Dremio, Firebolt, Pinot, Vertica, and Opensearch. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org