You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Alexander Reelsen (Created) (JIRA)" <ji...@apache.org> on 2012/01/12 17:13:40 UTC

[jira] [Created] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
----------------------------------------------------------------------------

                 Key: OFBIZ-4657
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Alexander Reelsen


When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.

The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script

        <call-bsh><![CDATA[
            shipmentMethod = parameters.get("shipmentMethod");
            if (shipmentMethod != null) {
               arr = shipmentMethod.split( "@" );
               parameters.put("shipmentMethodTypeId", arr[0]);
               parameters.put("carrierPartyId", arr[1]);
               parameters.put("carrierRoleTypeId", arr[2]);
            }
        ]]></call-bsh>

Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.

        <call-bsh><![CDATA[
            shipmentMethod = parameters.get("shipmentMethod");
            if (shipmentMethod != null) {
               arr = shipmentMethod.split( "@" );
               if (arr.length >= 3) {
                   parameters.put("shipmentMethodTypeId", arr[0]);
                   parameters.put("carrierPartyId", arr[1]);
                   parameters.put("carrierRoleTypeId", arr[2]);
               }
            }
        ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

Posted by "Paul Foxworthy (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186470#comment-13186470 ] 

Paul Foxworthy commented on OFBIZ-4657:
---------------------------------------

Due to the line at https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl?hb=true#to255,  I would expect that there should always be two @ characters. As Jacques says, that line was was changed in 4389.

If that is not the case, there *should* be an exception. I think the error should not be quietly ignored.

Alexander, is the problem that you are combining a newer OrderServices.xml, expecting two @ characters, with an older version of ordershippinginfo.ftl?
                
> ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Alexander Reelsen
>            Assignee: Jacques Le Roux
>
> When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.
> The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                parameters.put("shipmentMethodTypeId", arr[0]);
>                parameters.put("carrierPartyId", arr[1]);
>                parameters.put("carrierRoleTypeId", arr[2]);
>             }
>         ]]></call-bsh>
> Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                if (arr.length >= 3) {
>                    parameters.put("shipmentMethodTypeId", arr[0]);
>                    parameters.put("carrierPartyId", arr[1]);
>                    parameters.put("carrierRoleTypeId", arr[2]);
>                }
>             }
>         ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

Posted by "Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186532#comment-13186532 ] 

Jacques Le Roux commented on OFBIZ-4657:
----------------------------------------

Alexander,

Could you confirm you have the same issue with trunk HEAD?
                
> ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Alexander Reelsen
>            Assignee: Jacques Le Roux
>
> When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.
> The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                parameters.put("shipmentMethodTypeId", arr[0]);
>                parameters.put("carrierPartyId", arr[1]);
>                parameters.put("carrierRoleTypeId", arr[2]);
>             }
>         ]]></call-bsh>
> Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                if (arr.length >= 3) {
>                    parameters.put("shipmentMethodTypeId", arr[0]);
>                    parameters.put("carrierPartyId", arr[1]);
>                    parameters.put("carrierRoleTypeId", arr[2]);
>                }
>             }
>         ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

Posted by "Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186537#comment-13186537 ] 

Jacques Le Roux commented on OFBIZ-4657:
----------------------------------------

Alexander,

I had another look at your patch. It's buid againt revision 1164029. There is no such revision in OFBiz commits. But this is around early September. So finally it should not be related to OFBIZ-4389 and r1167116...

Still, could you confirm you can reproduce with trunk HEAD? Because, of course we apply our patches against trunk HEAD...

Thanks
                
> ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Alexander Reelsen
>            Assignee: Jacques Le Roux
>
> When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.
> The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                parameters.put("shipmentMethodTypeId", arr[0]);
>                parameters.put("carrierPartyId", arr[1]);
>                parameters.put("carrierRoleTypeId", arr[2]);
>             }
>         ]]></call-bsh>
> Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                if (arr.length >= 3) {
>                    parameters.put("shipmentMethodTypeId", arr[0]);
>                    parameters.put("carrierPartyId", arr[1]);
>                    parameters.put("carrierRoleTypeId", arr[2]);
>                }
>             }
>         ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

Posted by "Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185165#comment-13185165 ] 

Jacques Le Roux commented on OFBIZ-4657:
----------------------------------------

This sounds to be related to OFBIZ-4389, I will have a look...
                
> ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Alexander Reelsen
>
> When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.
> The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                parameters.put("shipmentMethodTypeId", arr[0]);
>                parameters.put("carrierPartyId", arr[1]);
>                parameters.put("carrierRoleTypeId", arr[2]);
>             }
>         ]]></call-bsh>
> Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                if (arr.length >= 3) {
>                    parameters.put("shipmentMethodTypeId", arr[0]);
>                    parameters.put("carrierPartyId", arr[1]);
>                    parameters.put("carrierRoleTypeId", arr[2]);
>                }
>             }
>         ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

Posted by "Paul Foxworthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277265#comment-13277265 ] 

Paul Foxworthy edited comment on OFBIZ-4657 at 5/16/12 11:35 PM:
-----------------------------------------------------------------

Turns out there is a problem after all. I'm pretty sure this is the same problem as OFBIZ-4865, which has a patch. Thanks to Leon for tracking it down.
                
      was (Author: paul_foxworthy):
    Turns out there is a problem after all. I'm pretty sure this is the same problem as OFBIZ-4865, which has a patch. Thanks to Leon for tracking it.
                  
> ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Alexander Reelsen
>            Assignee: Jacques Le Roux
>
> When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.
> The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                parameters.put("shipmentMethodTypeId", arr[0]);
>                parameters.put("carrierPartyId", arr[1]);
>                parameters.put("carrierRoleTypeId", arr[2]);
>             }
>         ]]></call-bsh>
> Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                if (arr.length >= 3) {
>                    parameters.put("shipmentMethodTypeId", arr[0]);
>                    parameters.put("carrierPartyId", arr[1]);
>                    parameters.put("carrierRoleTypeId", arr[2]);
>                }
>             }
>         ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

Posted by "Jacques Le Roux (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4657:
--------------------------------------

    Assignee: Jacques Le Roux
    
> ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Alexander Reelsen
>            Assignee: Jacques Le Roux
>
> When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.
> The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                parameters.put("shipmentMethodTypeId", arr[0]);
>                parameters.put("carrierPartyId", arr[1]);
>                parameters.put("carrierRoleTypeId", arr[2]);
>             }
>         ]]></call-bsh>
> Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                if (arr.length >= 3) {
>                    parameters.put("shipmentMethodTypeId", arr[0]);
>                    parameters.put("carrierPartyId", arr[1]);
>                    parameters.put("carrierRoleTypeId", arr[2]);
>                }
>             }
>         ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

Posted by "Paul Foxworthy (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254316#comment-13254316 ] 

Paul Foxworthy commented on OFBIZ-4657:
---------------------------------------

Please close as not a problem.
                
> ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Alexander Reelsen
>            Assignee: Jacques Le Roux
>
> When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.
> The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                parameters.put("shipmentMethodTypeId", arr[0]);
>                parameters.put("carrierPartyId", arr[1]);
>                parameters.put("carrierRoleTypeId", arr[2]);
>             }
>         ]]></call-bsh>
> Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                if (arr.length >= 3) {
>                    parameters.put("shipmentMethodTypeId", arr[0]);
>                    parameters.put("carrierPartyId", arr[1]);
>                    parameters.put("carrierRoleTypeId", arr[2]);
>                }
>             }
>         ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

Posted by "Jacques Le Roux (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4657.
----------------------------------

    Resolution: Not A Problem

Thanks for confirmation Paul
                
> ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Alexander Reelsen
>            Assignee: Jacques Le Roux
>
> When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.
> The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                parameters.put("shipmentMethodTypeId", arr[0]);
>                parameters.put("carrierPartyId", arr[1]);
>                parameters.put("carrierRoleTypeId", arr[2]);
>             }
>         ]]></call-bsh>
> Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                if (arr.length >= 3) {
>                    parameters.put("shipmentMethodTypeId", arr[0]);
>                    parameters.put("carrierPartyId", arr[1]);
>                    parameters.put("carrierRoleTypeId", arr[2]);
>                }
>             }
>         ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

Posted by "Paul Foxworthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277265#comment-13277265 ] 

Paul Foxworthy edited comment on OFBIZ-4657 at 5/16/12 11:34 PM:
-----------------------------------------------------------------

Turns out there is a problem after all. I'm pretty sure this is the same problem as OFBIZ-4865, which has a patch. Thanks to Leon for tracking it.
                
      was (Author: paul_foxworthy):
    I'm pretty sure this is the same problem as OFBIZ-4865, which has a patch. Thanks to Leon for tracking down the problem.
                  
> ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Alexander Reelsen
>            Assignee: Jacques Le Roux
>
> When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.
> The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                parameters.put("shipmentMethodTypeId", arr[0]);
>                parameters.put("carrierPartyId", arr[1]);
>                parameters.put("carrierRoleTypeId", arr[2]);
>             }
>         ]]></call-bsh>
> Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                if (arr.length >= 3) {
>                    parameters.put("shipmentMethodTypeId", arr[0]);
>                    parameters.put("carrierPartyId", arr[1]);
>                    parameters.put("carrierRoleTypeId", arr[2]);
>                }
>             }
>         ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OFBIZ-4657) ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

Posted by "Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185166#comment-13185166 ] 

Jacques Le Roux commented on OFBIZ-4657:
----------------------------------------

In the meantime, you could try to revert r1167116, seemingly the same problem should exists for releases...

                
> ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4657
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Alexander Reelsen
>            Assignee: Jacques Le Roux
>
> When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.
> The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                parameters.put("shipmentMethodTypeId", arr[0]);
>                parameters.put("carrierPartyId", arr[1]);
>                parameters.put("carrierRoleTypeId", arr[2]);
>             }
>         ]]></call-bsh>
> Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.
>         <call-bsh><![CDATA[
>             shipmentMethod = parameters.get("shipmentMethod");
>             if (shipmentMethod != null) {
>                arr = shipmentMethod.split( "@" );
>                if (arr.length >= 3) {
>                    parameters.put("shipmentMethodTypeId", arr[0]);
>                    parameters.put("carrierPartyId", arr[1]);
>                    parameters.put("carrierRoleTypeId", arr[2]);
>                }
>             }
>         ]]></call-bsh>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira