[GitHub] [maven-apache-parent] hboutemy edited a comment on pull request #31: MPOM-260 configure javadoc for reproducible builds

[GitBox <gi...@apache.org>]

hboutemy edited a comment on pull request #31:
URL: https://github.com/apache/maven-apache-parent/pull/31#issuecomment-754941359


   this PR mixes many many different things:
   - create a property to define maven-javadoc-plugin version: no, please don't do that
   - remove one source of noise in generated javadoc: timestamp = a good idea
   - the hope that it will be sufficient to have reproducible javadoc: IMHO, you're dreaming, there are so many moving parts in javadoc generated html (with links to external components javadoc) that I personnally stopped dreaming about it
   - the question of configuring the reporting section in addition to configuring the plugin, which should not be necessary since maven-site-plugin 3.4: see https://maven.apache.org/plugins/maven-site-plugin/history.html (some documentation here and there should probably require some updates to explain how things evolved over time)
   
   all in all, in this PR, I would only keep the timestamp removal in plugin configuration (and not advertise it as "configure javadoc for reproducible builds", because it's only a little part of what is needed for that)
   anything else would require separate discussion


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org