[GitHub] [arrow] dragosmg commented on a change in pull request #12622: ARROW-15802 [R] bindings for lubridate::make_datetime() and lubridate::make_date()

[GitBox <gi...@apache.org>]

dragosmg commented on a change in pull request #12622:
URL: https://github.com/apache/arrow/pull/12622#discussion_r826758769



##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -974,3 +974,50 @@ test_that("date() errors with unsupported inputs", {
     regexp = "Unsupported cast from double to date32 using function cast_date32"
   )
 })
+
+test_that("make_date & make_datetime", {
+  set.seed(12345)
+  test_df <- tibble(
+    year = sample(1969:2069, 12),
+    month = 1:12,
+    day = sample(1:28, 12, replace = TRUE),
+    hour = sample(0:23, 12, replace = TRUE),
+    min = sample(0:59, 12),
+    sec = sample(0:59, 12)
+  )

Review comment:
       I have a feeling we might need to wait to implement NA _progagation_ for `make_datetime()` and friends. I think the most elegant solution would rely on `strptime` returning an NA ([ARROW-15665](https://issues.apache.org/jira/browse/ARROW-15665))   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org