You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2010/12/09 18:34:01 UTC

[jira] Commented: (THRIFT-1020) OCaml compiler generates invalid OCaml

    [ https://issues.apache.org/jira/browse/THRIFT-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969825#action_12969825 ] 

Bryan Duxbury commented on THRIFT-1020:
---------------------------------------

Why does this patch add a ".0" even when the constant is already a double? Wouldn't that result in multiple decimal places?

> OCaml compiler generates invalid OCaml
> --------------------------------------
>
>                 Key: THRIFT-1020
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1020
>             Project: Thrift
>          Issue Type: Bug
>          Components: OCaml - Compiler
>    Affects Versions: 0.7
>            Reporter: Richard Low
>         Attachments: ocaml-fixes.patch
>
>
> There are a couple of bugs in the current thrift that cause invalid OCaml to be generated.  One problem is that floats can be written without a decimal point.  The other is that the copy type in the mli file is wrong.
> The attached patch fixes both of the issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.