You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/07 13:57:38 UTC

[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

JiriOndrusek opened a new pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462


   Fixes: https://github.com/apache/camel-quarkus/issues/1430
   
   [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
   [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
   [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-676118305


   I will take care


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-666993960


   @ppalaga I'll rebase it. I think, that the last 2 change requests will disappear, as they were not the part of the original changes, but it seems that they were added during some  rebases. 
   I'll fix the first change request (about performance)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-664801183






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-667061027


   @ppalaga I'll change it into separate commit. Now it is amended


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#discussion_r463453405



##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/BaseModel.java
##########
@@ -110,6 +112,91 @@ public synchronized RouteDefinition getRouteDefinition(String id) {
         return null;
     }
 
+    @Override
+    public List<RouteTemplateDefinition> getRouteTemplateDefinitions() {
+        return routeTemplateDefinitions;
+    }
+
+    @Override
+    public RouteTemplateDefinition getRouteTemplateDefinition(String id) {
+        for (RouteTemplateDefinition route : routeTemplateDefinitions) {
+            if (route.idOrCreate(camelContext.adapt(ExtendedCamelContext.class).getNodeIdFactory()).equals(id)) {
+                return route;
+            }
+        }
+        return null;
+    }
+
+    @Override
+    public void addRouteTemplateDefinitions(Collection<RouteTemplateDefinition> routeTemplateDefinitions) throws Exception {
+        if (routeTemplateDefinitions == null || routeTemplateDefinitions.isEmpty()) {
+            return;
+        }
+        this.routeTemplateDefinitions.addAll(routeTemplateDefinitions);
+    }
+
+    @Override
+    public void addRouteTemplateDefinition(RouteTemplateDefinition routeTemplateDefinition) throws Exception {
+        this.routeTemplateDefinitions.addAll(routeTemplateDefinitions);

Review comment:
       Does not look right. Perhaps this?
   ```suggestion
           this.routeTemplateDefinitions.addAll(routeTemplateDefinition);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-667051132


   > I've embedded all 3 fixes into this PR (they are all from current camel-master branch) I think that creating a simple PR for all 3 of them could be better solution, what do you think?
   
   No problem to have unrelated changes in one PR, as long as they are in separate commits. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-676009690


   Good to merge from my point of view


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek closed pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek closed pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#discussion_r450944686



##########
File path: .github/test-categories.yaml
##########
@@ -105,6 +105,7 @@ platform:
   - platform-http-engine
   - reactive-streams
   - rest-openapi
+  - threadpoolfactory-vertx

Review comment:
       Because there is no dedicated integration test module for `threadpoolfactory-vertx`. You may need to add it to the list of exclusions in `scripts/validate-github-workflows.groovy` in order to prevent the validation checks from failing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-655339641


   @aldettinger I've fixed doc link according your suggestion (from the content of the suggested page it is the correct page)
   @jamesnetherton I've removed this module from `test-categories.yaml` because it doesn't have a separate testing module, is this state correct?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-666996977


   @ppalaga I see that these 2 last issues are already in camel-master, I'll fix both of them.
   https://github.com/apache/camel-quarkus/blob/camel-master/extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/BaseModel.java#L140
   https://github.com/apache/camel-quarkus/blob/camel-master/extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/BaseModel.java#L145


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#discussion_r450931852



##########
File path: docs/modules/ROOT/pages/extensions/threadpoolfactory-vertx.adoc
##########
@@ -0,0 +1,28 @@
+// Do not edit directly!
+// This file was generated by camel-quarkus-maven-plugin:update-extension-doc-page
+
+[[threadpoolfactory-vertx]]
+= ThreadPoolFactory Vert.x
+
+[.badges]
+[.badge-key]##Since Camel Quarkus##[.badge-version]##1.0.0-CR4## [.badge-key]##JVM##[.badge-supported]##supported## [.badge-key]##Native##[.badge-supported]##supported##
+
+ThreadPoolFactory for camel-core using Vert.x
+
+== What's inside
+
+* https://camel.apache.org/components/latest/others/threadpoolfactory-vertx.html[ThreadPoolFactory Vert.x]

Review comment:
       threadpoolfactory-vertx.html: is it https://camel.apache.org/components/latest/others/reactive-threadpoolfactory-vertx.html ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] davsclaus commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-664773831






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#discussion_r463452537



##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/BaseModel.java
##########
@@ -110,6 +112,91 @@ public synchronized RouteDefinition getRouteDefinition(String id) {
         return null;
     }
 
+    @Override
+    public List<RouteTemplateDefinition> getRouteTemplateDefinitions() {
+        return routeTemplateDefinitions;
+    }
+
+    @Override
+    public RouteTemplateDefinition getRouteTemplateDefinition(String id) {
+        for (RouteTemplateDefinition route : routeTemplateDefinitions) {
+            if (route.idOrCreate(camelContext.adapt(ExtendedCamelContext.class).getNodeIdFactory()).equals(id)) {

Review comment:
       ```suggestion
           final ... nodeIdFactory = camelContext.adapt(ExtendedCamelContext.class).getNodeIdFactory();
           for (RouteTemplateDefinition route : routeTemplateDefinitions) {
               if (route.idOrCreate(nodeIdFactory).equals(id)) {
   ```
   
   It would be more effective to get the factory once before starting the loop.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#discussion_r463453838



##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/BaseModel.java
##########
@@ -110,6 +112,91 @@ public synchronized RouteDefinition getRouteDefinition(String id) {
         return null;
     }
 
+    @Override
+    public List<RouteTemplateDefinition> getRouteTemplateDefinitions() {
+        return routeTemplateDefinitions;
+    }
+
+    @Override
+    public RouteTemplateDefinition getRouteTemplateDefinition(String id) {
+        for (RouteTemplateDefinition route : routeTemplateDefinitions) {
+            if (route.idOrCreate(camelContext.adapt(ExtendedCamelContext.class).getNodeIdFactory()).equals(id)) {
+                return route;
+            }
+        }
+        return null;
+    }
+
+    @Override
+    public void addRouteTemplateDefinitions(Collection<RouteTemplateDefinition> routeTemplateDefinitions) throws Exception {
+        if (routeTemplateDefinitions == null || routeTemplateDefinitions.isEmpty()) {
+            return;
+        }
+        this.routeTemplateDefinitions.addAll(routeTemplateDefinitions);
+    }
+
+    @Override
+    public void addRouteTemplateDefinition(RouteTemplateDefinition routeTemplateDefinition) throws Exception {
+        this.routeTemplateDefinitions.addAll(routeTemplateDefinitions);
+    }
+
+    @Override
+    public void removeRouteTemplateDefinitions(Collection<RouteTemplateDefinition> routeTemplateDefinitions) throws Exception {
+        routeTemplateDefinitions.removeAll(routeTemplateDefinitions);

Review comment:
       Does not look right either. Maybe this?
   ```suggestion
           this.routeTemplateDefinitions.removeAll(routeTemplateDefinitions);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-661905888


   Check problem is caused by failing debezium test. Error is caused by an issue in debezium 1.2.0.Final - https://github.com/apache/camel-quarkus/issues/1490


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-655391775


   Test failure is not connected to this change: 
   >There are uncommitted changes
   HEAD detached at pull/1462/merge
   Changes not staged for commit:
     (use "git add <file>..." to update what will be committed)
     (use "git restore <file>..." to discard changes in working directory)
   	modified:   docs/modules/ROOT/pages/extensions/aws-s3.adoc
   	modified:   docs/modules/ROOT/pages/extensions/aws2-s3.adoc
   	modified:   docs/modules/ROOT/pages/list-of-camel-quarkus-extensions.adoc
   
   Restarting test (locally after build from test revision, there is nothing unstaged)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-655343014


   > is this state correct
   
   Yep - if the itest module does not exist, then there's no need to reference it in `test-categories.yaml`. Your new tests are in `main` which is already specified in that file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-667000346


   @ppalaga I've embedded all 3 fixes into this PR (they are all from current camel-master branch) I think that creating a simple PR for all 3 of them could be better solution, what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga merged pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#discussion_r463450810



##########
File path: docs/modules/ROOT/pages/extensions/threadpoolfactory-vertx.adoc
##########
@@ -0,0 +1,28 @@
+// Do not edit directly!
+// This file was generated by camel-quarkus-maven-plugin:update-extension-doc-page
+
+[[threadpoolfactory-vertx]]
+= ThreadPoolFactory Vert.x
+
+[.badges]
+[.badge-key]##Since Camel Quarkus##[.badge-version]##1.0.0-CR4## [.badge-key]##JVM##[.badge-supported]##supported## [.badge-key]##Native##[.badge-supported]##supported##
+
+ThreadPoolFactory for camel-core using Vert.x
+
+== What's inside
+
+* https://camel.apache.org/components/latest/others/threadpoolfactory-vertx.html[ThreadPoolFactory Vert.x]

Review comment:
       Filed a followup https://github.com/apache/camel-quarkus/issues/1506




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] lburgazzoli commented on pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#issuecomment-676109481


   @ppalaga @jamesnetherton ok to merge ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#discussion_r463454536



##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/BaseModel.java
##########
@@ -110,6 +112,91 @@ public synchronized RouteDefinition getRouteDefinition(String id) {
         return null;
     }
 
+    @Override
+    public List<RouteTemplateDefinition> getRouteTemplateDefinitions() {
+        return routeTemplateDefinitions;
+    }
+
+    @Override
+    public RouteTemplateDefinition getRouteTemplateDefinition(String id) {
+        for (RouteTemplateDefinition route : routeTemplateDefinitions) {
+            if (route.idOrCreate(camelContext.adapt(ExtendedCamelContext.class).getNodeIdFactory()).equals(id)) {

Review comment:
       No problem, I'll refactor it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1462: Extension for camel-threadpoolfactory-vertx #1430

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1462:
URL: https://github.com/apache/camel-quarkus/pull/1462#discussion_r463454909



##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/BaseModel.java
##########
@@ -110,6 +112,91 @@ public synchronized RouteDefinition getRouteDefinition(String id) {
         return null;
     }
 
+    @Override
+    public List<RouteTemplateDefinition> getRouteTemplateDefinitions() {
+        return routeTemplateDefinitions;
+    }
+
+    @Override
+    public RouteTemplateDefinition getRouteTemplateDefinition(String id) {
+        for (RouteTemplateDefinition route : routeTemplateDefinitions) {
+            if (route.idOrCreate(camelContext.adapt(ExtendedCamelContext.class).getNodeIdFactory()).equals(id)) {
+                return route;
+            }
+        }
+        return null;
+    }
+
+    @Override
+    public void addRouteTemplateDefinitions(Collection<RouteTemplateDefinition> routeTemplateDefinitions) throws Exception {
+        if (routeTemplateDefinitions == null || routeTemplateDefinitions.isEmpty()) {
+            return;
+        }
+        this.routeTemplateDefinitions.addAll(routeTemplateDefinitions);
+    }
+
+    @Override
+    public void addRouteTemplateDefinition(RouteTemplateDefinition routeTemplateDefinition) throws Exception {
+        this.routeTemplateDefinitions.addAll(routeTemplateDefinitions);

Review comment:
       I agree that current state doesn't make sense. I'll fix it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org