You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Aron Sogor (JIRA)" <ji...@apache.org> on 2009/12/29 21:35:29 UTC

[jira] Created: (THRIFT-668) Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile

Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile
-------------------------------------------------------------------------------------------------------------------------------------------

                 Key: THRIFT-668
                 URL: https://issues.apache.org/jira/browse/THRIFT-668
             Project: Thrift
          Issue Type: Bug
          Components: Compiler (Java)
    Affects Versions: 0.2
            Reporter: Aron Sogor


Generate code in stub:

      lastComparison = TBaseHelper.compareTo(authExp, typedOther.authExp); // FAILS as autheException is not comperable
      if (lastComparison != 0) {
        return lastComparison;
      }

Using an idl like:

exception AuthException 
{
  1: string key,
  2: map<string, string> messageParams
}

Take out the map->AuteException is Comperable->problem worked around

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (THRIFT-668) Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury reassigned THRIFT-668:
------------------------------------

    Assignee: Bryan Duxbury

> Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-668
>                 URL: https://issues.apache.org/jira/browse/THRIFT-668
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java)
>    Affects Versions: 0.2
>            Reporter: Aron Sogor
>            Assignee: Bryan Duxbury
>
> Generate code in stub:
>       lastComparison = TBaseHelper.compareTo(authExp, typedOther.authExp); // FAILS as autheException is not comperable
>       if (lastComparison != 0) {
>         return lastComparison;
>       }
> Using an idl like:
> exception AuthException 
> {
>   1: string key,
>   2: map<string, string> messageParams
> }
> Take out the map->AuteException is Comperable->problem worked around

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (THRIFT-668) Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile

Posted by "Aron Sogor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795605#action_12795605 ] 

Aron Sogor commented on THRIFT-668:
-----------------------------------

Patch worked!

> Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-668
>                 URL: https://issues.apache.org/jira/browse/THRIFT-668
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java)
>    Affects Versions: 0.2
>            Reporter: Aron Sogor
>            Assignee: Bryan Duxbury
>         Attachments: thrift-688.patch
>
>
> Generate code in stub:
>       lastComparison = TBaseHelper.compareTo(authExp, typedOther.authExp); // FAILS as autheException is not comperable
>       if (lastComparison != 0) {
>         return lastComparison;
>       }
> Using an idl like:
> exception AuthException 
> {
>   1: string key,
>   2: map<string, string> messageParams
> }
> Take out the map->AuteException is Comperable->problem worked around

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (THRIFT-668) Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury resolved THRIFT-668.
----------------------------------

    Resolution: Fixed

I just committed this.

> Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-668
>                 URL: https://issues.apache.org/jira/browse/THRIFT-668
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java)
>    Affects Versions: 0.2
>            Reporter: Aron Sogor
>            Assignee: Bryan Duxbury
>         Attachments: thrift-688.patch
>
>
> Generate code in stub:
>       lastComparison = TBaseHelper.compareTo(authExp, typedOther.authExp); // FAILS as autheException is not comperable
>       if (lastComparison != 0) {
>         return lastComparison;
>       }
> Using an idl like:
> exception AuthException 
> {
>   1: string key,
>   2: map<string, string> messageParams
> }
> Take out the map->AuteException is Comperable->problem worked around

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (THRIFT-668) Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated THRIFT-668:
---------------------------------

    Attachment: thrift-688.patch

I think this patch fixes the problem. Can you try it out?

> Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-668
>                 URL: https://issues.apache.org/jira/browse/THRIFT-668
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java)
>    Affects Versions: 0.2
>            Reporter: Aron Sogor
>            Assignee: Bryan Duxbury
>         Attachments: thrift-688.patch
>
>
> Generate code in stub:
>       lastComparison = TBaseHelper.compareTo(authExp, typedOther.authExp); // FAILS as autheException is not comperable
>       if (lastComparison != 0) {
>         return lastComparison;
>       }
> Using an idl like:
> exception AuthException 
> {
>   1: string key,
>   2: map<string, string> messageParams
> }
> Take out the map->AuteException is Comperable->problem worked around

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.