You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/12/14 01:52:32 UTC

[GitHub] [skywalking-banyandb] hanahmily commented on pull request #229: Defining "IN" and "NOT IN" APIs in query module.Fixes apache/skywalking [BanyanDB]#9759

hanahmily commented on PR #229:
URL: https://github.com/apache/skywalking-banyandb/pull/229#issuecomment-1350234524

   @DevPJ9 The codes seem good. Could you add a test case to verify it? The `or` operation could be transformed to `in` easily. You can refer to https://github.com/apache/skywalking-banyandb/blob/main/test/cases/measure/data/input/linked_or.yaml to write the case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org