You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by djzort <gi...@git.apache.org> on 2017/05/05 12:57:07 UTC
[GitHub] thrift pull request #1261: Replace the use of Indirect Object Syntax calls t...
GitHub user djzort opened a pull request:
https://github.com/apache/thrift/pull/1261
Replace the use of Indirect Object Syntax calls to new()
Using Indirect Object Syntax to instantiate objects is not recommended as per https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods
I have update the output to follow the recommended Class->new() syntax
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djzort/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1261.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1261
----
commit 1cabda781bfdf84e227f47ab0e433af12c6939c9
Author: Dean Hamstead <de...@fragfest.com.au>
Date: 2017-05-05T12:53:26Z
Replace the use of Indirect Object Syntax calls to new() with recommended Class->Method() syntax
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1261: Replace the use of Indirect Object Syntax calls to new()
Posted by djzort <gi...@git.apache.org>.
Github user djzort commented on the issue:
https://github.com/apache/thrift/pull/1261
I finally made a jira account, but i need a month to recover from the horrors
---
[GitHub] thrift issue #1261: THRIFT-4382: Replace the use of Indirect Object Syntax c...
Posted by bforbis <gi...@git.apache.org>.
Github user bforbis commented on the issue:
https://github.com/apache/thrift/pull/1261
It would probably be a good idea to also update the code at `tutorial/perl/*` so that the main perl tutorial uses this preferred syntax.
---
[GitHub] thrift issue #1261: Replace the use of Indirect Object Syntax calls to new()
Posted by djzort <gi...@git.apache.org>.
Github user djzort commented on the issue:
https://github.com/apache/thrift/pull/1261
I will get to it :)
---
[GitHub] thrift issue #1261: Replace the use of Indirect Object Syntax calls to new()
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1261
Post the Jira issue (THRIFT-nnnn) in here when you have one as well - thanks.
---
[GitHub] thrift issue #1261: Replace the use of Indirect Object Syntax calls to new()
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1261
Could you rebase on master and refresh the PR so we get a clean build, now that CI is stable again? Also we need a Jira ticket for the change:
https://thrift.apache.org/docs/HowToContribute
Thanks.
---
[GitHub] thrift issue #1261: THRIFT-4382: Replace the use of Indirect Object Syntax c...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1261
If you are able to finish this up and do the tutorial code, or if you are not able to complete this, please let me know.
---
[GitHub] thrift issue #1261: THRIFT-4382: Replace the use of Indirect Object Syntax c...
Posted by djzort <gi...@git.apache.org>.
Github user djzort commented on the issue:
https://github.com/apache/thrift/pull/1261
it's still on my TODO list, but is very low. I will get to it sooner or later.
---
[GitHub] thrift issue #1261: THRIFT-4382: Replace the use of Indirect Object Syntax c...
Posted by djzort <gi...@git.apache.org>.
Github user djzort commented on the issue:
https://github.com/apache/thrift/pull/1261
This should now comply with the contributors policy
---
[GitHub] thrift issue #1261: Replace the use of Indirect Object Syntax calls to new()
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1261
@djzort reminder we need a Jira THRIFT issue and squash and rebase on master.
---