You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ongchi (via GitHub)" <gi...@apache.org> on 2023/12/21 14:06:55 UTC

[PR] Add missing array functions [arrow-datafusion-python]

ongchi opened a new pull request, #551:
URL: https://github.com/apache/arrow-datafusion-python/pull/551

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Part of  #463 
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   Array functions should be implemented for the Python API.
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Array functions:
   - array_append
   - array_concat
   - array_cat
   - array_dims
   - list_dims
   - array_element
   - array_extract
   - list_element
   - list_extract
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   
   Yes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add missing array functions [arrow-datafusion-python]

Posted by "ongchi (via GitHub)" <gi...@apache.org>.
ongchi commented on code in PR #551:
URL: https://github.com/apache/arrow-datafusion-python/pull/551#discussion_r1434125817


##########
datafusion/tests/test_functions.py:
##########
@@ -25,6 +25,8 @@
 from datafusion import functions as f
 from datafusion import literal
 
+np.seterr(invalid="ignore")

Review Comment:
   I think it's reasonable to turn off warnings of invalid floating-point errors, which can safely be ignored in test cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add missing array functions [arrow-datafusion-python]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #551:
URL: https://github.com/apache/arrow-datafusion-python/pull/551


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org