[GitHub] [arrow] lidavidm commented on a change in pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#discussion_r802804968



##########
File path: cpp/src/arrow/flight/client.h
##########
@@ -323,8 +323,19 @@ class ARROW_FLIGHT_EXPORT FlightClient {
     return DoExchange({}, descriptor, writer, reader);
   }
 
+  /// \brief Explicitly shut down and clean up the client.
+  ///
+  /// For backwards compatibility, this will be implicitly called by
+  /// the destructor if not already called, but this gives the
+  /// application no chance to handle errors, so it is recommended to
+  /// explicitly close the client.
+  ///
+  /// \since 8.0.0
+  Status Close();
+
  private:
   FlightClient();
+  Status CheckOpen();

Review comment:
       Ah whoops, fixed - thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org