You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by MrBago <gi...@git.apache.org> on 2018/01/03 23:25:41 UTC
[GitHub] spark pull request #20143: [SPARK-22949][ML] Apply CrossValidator approach t...
GitHub user MrBago opened a pull request:
https://github.com/apache/spark/pull/20143
[SPARK-22949][ML] Apply CrossValidator approach to Driver/Distributed memory tradeoff for TrainValidationSplit
## What changes were proposed in this pull request?
Avoid holding all models in memory for `TrainValidationSplit`.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MrBago/spark trainValidMemoryFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20143.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20143
----
commit 6aa46f8f652fc5da8346eae68755ac2b51e355a5
Author: Bago Amirbekian <ba...@...>
Date: 2018-01-03T23:12:34Z
Apply CrossValidator approach to Driver/Distributed memory tradeoff for
TrainValidationSplit.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20143: [SPARK-22949][ML] Apply CrossValidator approach to Drive...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20143
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85645/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20143: [SPARK-22949][ML] Apply CrossValidator approach t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20143
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20143: [SPARK-22949][ML] Apply CrossValidator approach to Drive...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/20143
LGTM
I'm going to merge this with master and branch-2.3, backporting as a fairly important bug fix
Thanks @MrBago !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20143: [SPARK-22949][ML] Apply CrossValidator approach to Drive...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20143
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20143: [SPARK-22949][ML] Apply CrossValidator approach to Drive...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20143
**[Test build #85645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85645/testReport)** for PR 20143 at commit [`6aa46f8`](https://github.com/apache/spark/commit/6aa46f8f652fc5da8346eae68755ac2b51e355a5).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20143: [SPARK-22949][ML] Apply CrossValidator approach to Drive...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20143
**[Test build #85645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85645/testReport)** for PR 20143 at commit [`6aa46f8`](https://github.com/apache/spark/commit/6aa46f8f652fc5da8346eae68755ac2b51e355a5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org