You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/04/06 23:50:21 UTC
[kudu-CR] KUDU-2689: Updated the function documentations with a better description of the return type.
raymond@phdata.io has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12952
Change subject: KUDU-2689: Updated the function documentations with a better description of the return type.
......................................................................
KUDU-2689: Updated the function documentations with a better description of the return type.
Changed '@return a PartialRow' to '@return this PartialRow' to clearly indicate that it's the current row that is being mutated rather than a new PartialRow.
Change-Id: I87b26e775075a0ce16da925df74240fef305f47a
---
A java/kudu-client/derby.log
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
3 files changed, 53 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/12952/1
--
To view, visit http://gerrit.cloudera.org:8080/12952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87b26e775075a0ce16da925df74240fef305f47a
Gerrit-Change-Number: 12952
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <ra...@phdata.io>
[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
raymond@phdata.io has abandoned this change. ( http://gerrit.cloudera.org:8080/12952 )
Change subject: KUDU-2689: Made PartialRow setters use a fluent-style.
......................................................................
Abandoned
Abandoning redundant change.
--
To view, visit http://gerrit.cloudera.org:8080/12952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I87b26e775075a0ce16da925df74240fef305f47a
Gerrit-Change-Number: 12952
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <ra...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12952
to look at the new patch set (#2).
Change subject: KUDU-2689: Made PartialRow setters use a fluent-style.
......................................................................
KUDU-2689: Made PartialRow setters use a fluent-style.
-Changed PartialRow return types from void to PartialRow so that the method calls can be chained.
-Changed '@return a PartialRow' to '@return this PartialRow' to clearly indicate that it's the current row that is being mutated rather than a new PartialRow.
-Removed redundant indentation.
[metrics] Remove incorrect comments
Data store in std::map with key type 'const char*' is not in
alphabetical order, and it's not needed to sort metrics.
Change-Id: Id8788c38b73c623616b3fb2b73fcb6973df4ec87
Reviewed-on: http://gerrit.cloudera.org:8080/12921
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
KUDU-2689: Made PartialRow setters use a fluent-style.
Changed PartialRow return types from void to PartialRow so that the method calls can be chained.
Change-Id: I3476fb3c0a28812e2732e6c6268f31a393928206
KUDU-2689: Updated the function documentations with a better description of the return type.
Changed '@return a PartialRow' to '@return this PartialRow' to clearly indicate that it's the current row that is being mutated rather than a new PartialRow.
Change-Id: I87b26e775075a0ce16da925df74240fef305f47a
---
A java/kudu-client/derby.log
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M src/kudu/util/metrics.cc
4 files changed, 156 insertions(+), 97 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/12952/2
--
To view, visit http://gerrit.cloudera.org:8080/12952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87b26e775075a0ce16da925df74240fef305f47a
Gerrit-Change-Number: 12952
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <ra...@phdata.io>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12952 )
Change subject: KUDU-2689: Made PartialRow setters use a fluent-style.
......................................................................
Patch Set 2:
Seems like you uploaded two changes for the same patch: this change, and https://gerrit.cloudera.org/c/12949. Since we've started to review the other one, could you abandon this one and roll any delta into the other?
--
To view, visit http://gerrit.cloudera.org:8080/12952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87b26e775075a0ce16da925df74240fef305f47a
Gerrit-Change-Number: 12952
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <ra...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 09 Apr 2019 04:57:43 +0000
Gerrit-HasComments: No