You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "EMsnap (via GitHub)" <gi...@apache.org> on 2023/04/14 08:15:51 UTC
[GitHub] [inlong] EMsnap opened a new pull request, #7856: [INLONG-7855][Sort] Fix Sort hang up reader in snapshot phase when reducing parallelism
EMsnap opened a new pull request, #7856:
URL: https://github.com/apache/inlong/pull/7856
### Prepare a Pull Request
- Fixes #7855
### Motivation
Fix Sort hang up reader in snapshot phase when reducing parallelism
1、When a subtask receives two chunk splits to read;
2、The first chunk reads perfectly, and then it will start a BinlogClient to read the binlogs from lw to hw in chunk1.
3、When the second chunk arrives the BinlogClient will be reused
4、So when reading chunk2 and start to read from lw to hw in chunk2, the binlog reader will be reused and the event listener in chunk1 will be reused also. So that the BINLOG_END event in chunk2 will never be received
### Modifications
remove the eventListener in the formal chunk
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #7856: [INLONG-7855][Sort] Fix Sort hang up reader in snapshot phase when reducing parallelism
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #7856:
URL: https://github.com/apache/inlong/pull/7856#issuecomment-1508228265
Please run `spotless:apply` to fix the check style error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7856: [INLONG-7855][Sort] Fix Sort hang up reader in snapshot phase when reducing parallelism
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7856:
URL: https://github.com/apache/inlong/pull/7856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7856: [INLONG-7855][Sort] Fix Sort hang up reader in snapshot phase when reducing parallelism
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7856:
URL: https://github.com/apache/inlong/pull/7856#discussion_r1166578364
##########
inlong-sort/sort-connectors/mysql-cdc/src/main/java/org/apache/inlong/sort/cdc/mysql/debezium/task/MySqlBinlogSplitReadTask.java:
##########
@@ -88,6 +94,29 @@ public MySqlBinlogSplitReadTask(
@Override
public void execute(ChangeEventSourceContext context) throws InterruptedException {
this.context = context;
+
+ /**
Review Comment:
Unsupported javadoc in the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on pull request #7856: [INLONG-7855][Sort] Fix Sort hang up reader in snapshot phase when reducing parallelism
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on PR #7856:
URL: https://github.com/apache/inlong/pull/7856#issuecomment-1512493862
> Please run `spotless:apply` to fix the check style error.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org