[GitHub] [superset] villebro commented on a diff in pull request #24160: fix(permalink): parsing urlParams as well

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on code in PR #24160:
URL: https://github.com/apache/superset/pull/24160#discussion_r1199726142


##########
superset/views/core.py:
##########
@@ -1959,7 +1959,7 @@ def dashboard_permalink(  # pylint: disable=no-self-use
         dashboard_id, state = value["dashboardId"], value.get("state", {})
         url = f"/superset/dashboard/{dashboard_id}?permalink_key={key}"
         if url_params := state.get("urlParams"):
-            params = parse.urlencode(url_params)
+            params = parse.urlencode(dict(url_params))

Review Comment:
   I'm surprised this wasn't caught by mypy or related tests. Can you double check that the the types are accurate, and see if the tests are correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org