You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/05/14 13:07:02 UTC

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5114: Introduce RedisResponse to SET executors

jdeppe-pivotal commented on a change in pull request #5114:
URL: https://github.com/apache/geode/pull/5114#discussion_r425121151



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
##########
@@ -349,9 +350,17 @@ private RedisCommandType(Executor executor, ParameterRequirements parameterRequi
     this.parameterRequirements = parameterRequirements;
   }
 
-  public void executeCommand(Command command, ExecutionHandlerContext executionHandlerContext) {
+  public RedisResponse executeCommand(Command command,
+      ExecutionHandlerContext executionHandlerContext) {
     parameterRequirements.checkParameters(command, executionHandlerContext);
+
+    if (executor instanceof ResponseExecutor) {

Review comment:
       Excellent! Good call.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org