You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/08/30 07:51:06 UTC

[GitHub] [ignite-3] ptupitsyn commented on pull request #296: IGNITE-15163 Support BitSet, Number, Decimal and Temporal types

ptupitsyn commented on pull request #296:
URL: https://github.com/apache/ignite-3/pull/296#issuecomment-908123055


   @AMashenkov 
   
   > unpack() method requires type-codes that enum resides in another module
   
   `ClientDataType` and `ClientMessageUnpacker` are in the same module.
   
   The reason for `dataType` parameter in `ClientMessageUnpacker#unpackObject` is that MessagePack uses varint encoding and there is no way to restore original value type after deserialization. For example, we could have `INT64` column, but if the value is small, MessagePack will encode it as `int16`. And we can't return `short` value in an `INT64` column to the user. So we have to use schema to deserialize values into their original form.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org